Resolve false positive on Rule0048

BusinessCentral.LinterCop.Test/Rule0048.cs

@@ -0,0 +1,43 @@
+namespace BusinessCentral.LinterCop.Test;
+
+public class Rule0048
+{
+    private string _testCaseDir = "";
+
+    [SetUp]
+    public void Setup()
+    {
+        _testCaseDir = Path.Combine(Directory.GetParent(Environment.CurrentDirectory)!.Parent!.Parent!.FullName,
+            "TestCases", "Rule0048");
+    }
+
+#if !LessThenSpring2024
+    [Test]
+    [TestCase("ErrorWithLiteralExpression")]
+    [TestCase("ErrorWithStrSubstNo")]
+    [TestCase("ErrorWithTextVariable")]
+#endif
+    public async Task HasDiagnostic(string testCase)
+    {
+        var code = await File.ReadAllTextAsync(Path.Combine(_testCaseDir, "HasDiagnostic", $"{testCase}.al"))
+            .ConfigureAwait(false);
+
+        var fixture = RoslynFixtureFactory.Create<Rule0048ErrorWithTextConstant>();
+        fixture.HasDiagnostic(code, DiagnosticDescriptors.Rule0048ErrorWithTextConstant.Id);
+    }
+
+    [Test]
+    [TestCase("ErrorWithErrorInfo")]
+    [TestCase("ErrorWithLabel")]
+#if !LessThenFall2024
+    [TestCase("ErrorWiththisLabel")]
+#endif
+    public async Task NoDiagnostic(string testCase)
+    {
+        var code = await File.ReadAllTextAsync(Path.Combine(_testCaseDir, "NoDiagnostic", $"{testCase}.al"))
+            .ConfigureAwait(false);
+
+        var fixture = RoslynFixtureFactory.Create<Rule0048ErrorWithTextConstant>();
+        fixture.NoDiagnosticAtMarker(code, DiagnosticDescriptors.Rule0048ErrorWithTextConstant.Id);
+    }
+}

BusinessCentral.LinterCop.Test/TestCases/Rule0048/HasDiagnostic/ErrorWithLiteralExpression.al

@@ -0,0 +1,7 @@
+codeunit 50100 MyCodeunit
+{
+    procedure MyProcedure()
+    begin
+        [|Error('Something went wrong...')|];
+    end;
+}

BusinessCentral.LinterCop.Test/TestCases/Rule0048/HasDiagnostic/ErrorWithStrSubstNo.al

@@ -0,0 +1,18 @@
+codeunit 50100 MyCodeunit
+{
+    procedure MyProcedure()
+    var
+        MyTable: Record MyTable;
+        UnexpectedErr: Label '%1 is not an valid Record.';
+    begin
+        [|Error(StrSubstNo(UnexpectedErr, MyTable.MyField))|];
+    end;
+}
+
+table 50100 MyTable
+{
+    fields
+    {
+        field(1; MyField; Integer) { }
+    }
+}

BusinessCentral.LinterCop.Test/TestCases/Rule0048/HasDiagnostic/ErrorWithTextVariable.al

@@ -0,0 +1,9 @@
+codeunit 50100 MyCodeunit
+{
+    procedure MyProcedure()
+    var
+        UnexpectedErr: Text;
+    begin
+        [|Error(UnexpectedErr)|];
+    end;
+}

BusinessCentral.LinterCop.Test/TestCases/Rule0048/NoDiagnostic/ErrorWithErrorInfo.al

@@ -0,0 +1,10 @@
+codeunit 50100 MyCodeunit
+{
+    procedure MyProcedure()
+    var
+        MyErrorInfo: ErrorInfo;
+    begin
+        MyErrorInfo := ErrorInfo.Create(GetLastErrorText());
+        [|Error(MyErrorInfo)|];
+    end;
+}

BusinessCentral.LinterCop.Test/TestCases/Rule0048/NoDiagnostic/ErrorWithLabel.al

@@ -0,0 +1,9 @@
+codeunit 50100 MyCodeunit
+{
+    procedure MyProcedure()
+    var
+        UnexpectedErr: Label 'Something went wrong...';
+    begin
+        [|Error(UnexpectedErr)|];
+    end;
+}

BusinessCentral.LinterCop.Test/TestCases/Rule0048/NoDiagnostic/ErrorWiththisLabel.al

@@ -0,0 +1,10 @@
+codeunit 50100 MyCodeunit
+{
+    var
+        UnexpectedErr: Label 'Something went wrong...';
+
+    procedure MyProcedure()
+    begin
+        [|Error(this.UnexpectedErr)|];
+    end;
+}

BusinessCentral.LinterCop/Design/Rule0048ErrorWithTextConstant.cs

@@ -30,6 +30,7 @@ private void AnalyzeErrorMethod(OperationAnalysisContext ctx)
         switch (operation.Arguments[0].Syntax.Kind)
         {
             case SyntaxKind.IdentifierName:
+            case SyntaxKind.MemberAccessExpression:
                 if (operation.Arguments[0].Value.Kind != OperationKind.ConversionExpression)
                     break;