Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC0091 labels should be translated #884

Conversation

ChristianHovenbitzer
Copy link
Contributor

Just wanted to put this out there if anyone else wants to or is working on something similar.

This rule is far from done or testable, it takes me a lot of time to properly implement this, but as a proof of concept it's already working and currently checking Symbols against translation files.

#804

@ChristianHovenbitzer
Copy link
Contributor Author

ChristianHovenbitzer commented Feb 15, 2025

There are still a few things unsolved, but I really want to get a first draft out there at least in prerelease.

  • Performance is somewhat okay with 3.2 seconds for about 1250 objects but I want to look into that again later
  • Query column captions are still missing
  • automated tests
  • update of the rules does not trigger when chaning the xlif files, not sure how to fix that

@ChristianHovenbitzer ChristianHovenbitzer marked this pull request as ready for review February 15, 2025 13:11
Copy link
Collaborator

@Arthurvdv Arthurvdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, looks promising! I have a few small remarks, if you could look into that?

Copy link
Collaborator

@Arthurvdv Arthurvdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes of the review.

We're almost there for merging into the Pre-release branch. Can you do a merge from the pre-release branch to resolve the merge conflicts?

@ChristianHovenbitzer
Copy link
Contributor Author

There are two errors with older versions.
I can change the GetManifest function like you did in rule LC0052, but I don't know how I can test this for the other function:
GetLanguageSymbolId

@Arthurvdv Arthurvdv changed the title LC0087 labels should be translated LC0091 labels should be translated Feb 18, 2025
@Arthurvdv
Copy link
Collaborator

Let's get this merged, looking forward to try this out on some of my projects.

This is a a great contribution to the LinterCop, thank you!

@Arthurvdv Arthurvdv merged commit 7bcf4ce into StefanMaron:prerelease Feb 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants