-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LC0091 labels should be translated #884
LC0091 labels should be translated #884
Conversation
…missing localizations in info
There are still a few things unsolved, but I really want to get a first draft out there at least in prerelease.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, looks promising! I have a few small remarks, if you could look into that?
BusinessCentral.LinterCop/Design/Rule0091LabelsShouldBeTranslated.cs
Outdated
Show resolved
Hide resolved
BusinessCentral.LinterCop/Design/Rule0091LabelsShouldBeTranslated.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes of the review.
We're almost there for merging into the Pre-release branch. Can you do a merge from the pre-release branch to resolve the merge conflicts?
…entral.LinterCop into LC0075-LabelsShouldBeTranslated
There are two errors with older versions. |
Let's get this merged, looking forward to try this out on some of my projects. This is a a great contribution to the LinterCop, thank you! |
Just wanted to put this out there if anyone else wants to or is working on something similar.
This rule is far from done or testable, it takes me a lot of time to properly implement this, but as a proof of concept it's already working and currently checking Symbols against translation files.
#804