Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rule0068 to LinterCop.ruleset.json #720

Merged
merged 19 commits into from
Aug 13, 2024
Merged

Add Rule0068 to LinterCop.ruleset.json #720

merged 19 commits into from
Aug 13, 2024

Conversation

StefanMaron
Copy link
Owner

This rule checks if the current object has missing permission when data access of any kind is used.

@StefanMaron
chore: Add Rule0067 to LinterCop.ruleset.json
47c9e11 
This rule checks if the current object has missing permission when data access of any kind is used.
@StefanMaron
Rename to rule 68
3a1eb08
@StefanMaron
Update readme to have the correct caption for the rule
a97732d
@StefanMaron StefanMaron marked this pull request as ready for review August 9, 2024 12:19
@StefanMaron StefanMaron changed the title Add Rule0067 to LinterCop.ruleset.json Add Rule0068 to LinterCop.ruleset.json Aug 12, 2024
@StefanMaron StefanMaron self-assigned this Aug 12, 2024
@StefanMaron StefanMaron requested a review from Arthurvdv August 12, 2024 06:17
@StefanMaron
Copy link
Owner Author

added the wiki page
https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0068

@StefanMaron
Copy link
Owner Author

@Arthurvdv
Please also have a look at the test step in the pipelines I added, if needed I can move that to another branch of course.
But it seems like it does not work for all compiler versions and I am not sure what the reason is for this.

@StefanMaron
Copy link
Owner Author

moved tests to its own branch
#723

@StefanMaron StefanMaron added enhancement New feature or request minor labels Aug 13, 2024
@StefanMaron StefanMaron merged commit 27c61e4 into prerelease Aug 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidorobben guidorobben guidorobben left review comments

@Arthurvdv Arthurvdv Awaiting requested review from Arthurvdv

Assignees

@StefanMaron StefanMaron

Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanMaron @guidorobben