Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if no runtime property in specified in the app.json #686

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add check if no runtime property in specified in the app.json #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BusinessCentral.LinterCop/Design/Rule0033AppManifestRuntimeBehind.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ private void CheckAppManifestRuntime(CompilationAnalysisContext ctx)
#endif

if (manifest == null) return;
if (manifest.Runtime == null) return;
if (manifest.Runtime == null || manifest.Runtime == RuntimeVersion.CurrentRelease) return; // In the case the runtime version isn't specified in the app.json it returns the RuntimeVersion.CurrentRelease
if (manifest.Application == null && manifest.Platform == null) return;

GetTargetProperty(manifest, out string propertyName, out Version propertyVersion);
Expand Down