fix(ci): pin stylua version and clear luacheck warnings - #1
Closed
StefanBartl wants to merge 1 commit into
Closed
Conversation
Both CI jobs had been red on every push since at least 2026-08-01, unrelated to any feature work. stylua's "latest" had drifted past what the repo was last formatted against, and luacheck fails on any warning (not just errors) with none being addressed. Pin stylua to v2.5.2 (what "latest" currently resolves to) and run `stylua --write .` to match, and fix the four outstanding luacheck warnings: an upvalue shadow in telemetry/init.lua, two shadowed `msgs` locals in composer_spec.lua, and an unused `uv` in lock_spec.lua. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
Author
|
Merging directly to main instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
luacheck lua docs/TESTS→ 0 warnings / 0 errors locallystylua --check .→ clean locallynvim --headless -u NONE -l docs/TESTS/run.lua→ LIB_TESTS_OK🤖 Generated with Claude Code