Skip to content

Add projects for obsolete/replaced packages #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 15, 2025
Merged

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Aug 11, 2025

Description

This PR adds projects for packages that don't exist in Steeltoe v4 anymore, so that we can push 4.0.0 versions that fail to compile. The error message points to the replacement package, if applicable, and links to https://steeltoe.io/docs/v3/obsolete. A readme.md for nuget.org is included with the same information.

The obsolete packages only build in Release configuration, to keep local builds efficient.

Output from Discovery 3x sample, after updating Steeltoe version

Visual Studio (requires a Rebuild)

image

CLI

> dotnet restore
Restore complete (0.7s)

Build succeeded in 0.7s
> dotnet build
Restore complete (0.4s)
  Fortune-Teller-UI failed with 1 error(s) and 5 warning(s) (0.0s)
    C:\Users\***\.nuget\packages\steeltoe.management.endpointcore\4.0.0\build\Steeltoe.Management.EndpointCore.targets(3,5): warning : The NuGet package Steeltoe.Management.EndpointCore has been replaced in Steeltoe v4. Reference Steeltoe.Management.Endpoint instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.extensions.configuration.cloudfoundrycore\4.0.0\build\Steeltoe.Extensions.Configuration.CloudFoundryCore.targets(3,5): warning : The NuGet package Steeltoe.Extensions.Configuration.CloudFoundryCore has been replaced in Steeltoe v4. Reference Steeltoe.Configuration.CloudFoundry instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.discovery.kubernetes\4.0.0\build\Steeltoe.Discovery.Kubernetes.targets(3,5): warning : The NuGet package Steeltoe.Discovery.Kubernetes is no longer available in Steeltoe v4. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.discovery.clientcore\4.0.0\build\Steeltoe.Discovery.ClientCore.targets(3,5): warning : The NuGet package Steeltoe.Discovery.ClientCore has been replaced in Steeltoe v4. Reference Steeltoe.Discovery.Configuration instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.connector.cloudfoundry\4.0.0\build\Steeltoe.Connector.CloudFoundry.targets(3,5): warning : The NuGet package Steeltoe.Connector.CloudFoundry has been replaced in Steeltoe v4. Reference Steeltoe.Connectors instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.connector.cloudfoundry\4.0.0\build\Steeltoe.Connector.CloudFoundry.targets(8,5): error : One or more Steeltoe package dependencies need attention. See the build warnings for details.
  Fortune-Teller-Service failed with 1 error(s) and 6 warning(s) (0.2s)
    C:\Users\***\.nuget\packages\steeltoe.management.endpointcore\4.0.0\build\Steeltoe.Management.EndpointCore.targets(3,5): warning : The NuGet package Steeltoe.Management.EndpointCore has been replaced in Steeltoe v4. Reference Steeltoe.Management.Endpoint instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.extensions.configuration.placeholdercore\4.0.0\build\Steeltoe.Extensions.Configuration.PlaceholderCore.targets(3,5): warning : The NuGet package Steeltoe.Extensions.Configuration.PlaceholderCore has been replaced in Steeltoe v4. Reference Steeltoe.Configuration.Placeholder instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.extensions.configuration.cloudfoundrycore\4.0.0\build\Steeltoe.Extensions.Configuration.CloudFoundryCore.targets(3,5): warning : The NuGet package Steeltoe.Extensions.Configuration.CloudFoundryCore has been replaced in Steeltoe v4. Reference Steeltoe.Configuration.CloudFoundry instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.discovery.kubernetes\4.0.0\build\Steeltoe.Discovery.Kubernetes.targets(3,5): warning : The NuGet package Steeltoe.Discovery.Kubernetes is no longer available in Steeltoe v4. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.discovery.clientcore\4.0.0\build\Steeltoe.Discovery.ClientCore.targets(3,5): warning : The NuGet package Steeltoe.Discovery.ClientCore has been replaced in Steeltoe v4. Reference Steeltoe.Discovery.Configuration instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.connector.cloudfoundry\4.0.0\build\Steeltoe.Connector.CloudFoundry.targets(3,5): warning : The NuGet package Steeltoe.Connector.CloudFoundry has been replaced in Steeltoe v4. Reference Steeltoe.Connectors instead. See https://steeltoe.io/docs/v3/obsolete for details.
    C:\Users\***\.nuget\packages\steeltoe.connector.cloudfoundry\4.0.0\build\Steeltoe.Connector.CloudFoundry.targets(8,5): error : One or more Steeltoe package dependencies need attention. See the build warnings for details.

Build failed with 2 error(s) and 11 warning(s) in 0.9s
Source used for code generation
Steeltoe.Bootstrap.Autoconfig -> Steeltoe.Bootstrap.AutoConfiguration
Steeltoe.CircuitBreaker.Abstractions
Steeltoe.CircuitBreaker.Hystrix.MetricsEventsCore
Steeltoe.CircuitBreaker.Hystrix.MetricsStreamCore
Steeltoe.CircuitBreaker.HystrixBase
Steeltoe.CircuitBreaker.HystrixCore
Steeltoe.Common.Abstractions -> Steeltoe.Common
Steeltoe.Common.Expression
Steeltoe.Common.Kubernetes
Steeltoe.Common.Retry
Steeltoe.Common.Security -> Steeltoe.Common.Certificates
Steeltoe.Common.Utils
Steeltoe.Connector.Abstractions -> Steeltoe.Connectors
Steeltoe.Connector.CloudFoundry -> Steeltoe.Connectors
Steeltoe.Connector.ConnectorBase -> Steeltoe.Connectors
Steeltoe.Connector.ConnectorCore -> Steeltoe.Connectors
Steeltoe.Connector.EF6Core
Steeltoe.Connector.EFCore -> Steeltoe.Connectors.EntityFrameworkCore
Steeltoe.Discovery.Abstractions -> Steeltoe.Common
Steeltoe.Discovery.ClientBase -> Steeltoe.Discovery.Configuration
Steeltoe.Discovery.ClientCore -> Steeltoe.Discovery.Configuration
Steeltoe.Discovery.Kubernetes
Steeltoe.Extensions.Configuration.Abstractions -> Steeltoe.Configuration.Abstractions
Steeltoe.Extensions.Configuration.CloudFoundryBase -> Steeltoe.Configuration.CloudFoundry
Steeltoe.Extensions.Configuration.CloudFoundryCore -> Steeltoe.Configuration.CloudFoundry
Steeltoe.Extensions.Configuration.ConfigServerBase -> Steeltoe.Configuration.ConfigServer
Steeltoe.Extensions.Configuration.ConfigServerCore -> Steeltoe.Configuration.ConfigServer
Steeltoe.Extensions.Configuration.Kubernetes.ServiceBinding -> Steeltoe.Configuration.Kubernetes.ServiceBindings
Steeltoe.Extensions.Configuration.KubernetesBase
Steeltoe.Extensions.Configuration.KubernetesCore
Steeltoe.Extensions.Configuration.PlaceholderBase -> Steeltoe.Configuration.Placeholder
Steeltoe.Extensions.Configuration.PlaceholderCore -> Steeltoe.Configuration.Placeholder
Steeltoe.Extensions.Configuration.RandomValueBase -> Steeltoe.Configuration.RandomValue
Steeltoe.Extensions.Configuration.SpringBootBase -> Steeltoe.Configuration.SpringBoot
Steeltoe.Extensions.Configuration.SpringBootCore -> Steeltoe.Configuration.SpringBoot
Steeltoe.Extensions.Logging.Abstractions -> Steeltoe.Logging.Abstractions
Steeltoe.Extensions.Logging.DynamicLogger -> Steeltoe.Logging.DynamicConsole
Steeltoe.Extensions.Logging.DynamicSerilogBase -> Steeltoe.Logging.DynamicSerilog
Steeltoe.Extensions.Logging.DynamicSerilogCore -> Steeltoe.Logging.DynamicSerilog
Steeltoe.Integration.Abstractions
Steeltoe.Integration.IntegrationBase
Steeltoe.Integration.RabbitMQ
Steeltoe.Management.CloudFoundryCore -> Steeltoe.Management.Endpoint
Steeltoe.Management.Diagnostics -> Steeltoe.Management.Endpoint
Steeltoe.Management.EndpointBase -> Steeltoe.Management.Endpoint
Steeltoe.Management.EndpointCore -> Steeltoe.Management.Endpoint
Steeltoe.Management.KubernetesCore
Steeltoe.Management.OpenTelemetryBase -> Steeltoe.Management.Prometheus
Steeltoe.Management.TaskCore -> Steeltoe.Management.Tasks
Steeltoe.Management.TracingBase -> Steeltoe.Management.Tracing
Steeltoe.Management.TracingCore -> Steeltoe.Management.Tracing
Steeltoe.Messaging.Abstractions
Steeltoe.Messaging.MessagingBase
Steeltoe.Messaging.RabbitMQ
Steeltoe.Security.Authentication.CloudFoundryBase -> Steeltoe.Security.Authentication.JwtBearer / Steeltoe.Security.Authentication.OpenIdConnect / Steeltoe.Security.Authorization.Certificate
Steeltoe.Security.Authentication.CloudFoundryCore -> Steeltoe.Security.Authentication.JwtBearer / Steeltoe.Security.Authentication.OpenIdConnect / Steeltoe.Security.Authorization.Certificate
Steeltoe.Security.Authentication.MtlsCore -> Steeltoe.Security.Authorization.Certificate
Steeltoe.Security.DataProtection.CredHubBase
Steeltoe.Security.DataProtection.CredHubCore
Steeltoe.Security.DataProtection.RedisCore -> Steeltoe.Security.DataProtection.Redis
Steeltoe.Stream.Abstractions
Steeltoe.Stream.Binder.RabbitMQ
Steeltoe.Stream.StreamBase

Closes #1242.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

Copy link

github-actions bot commented Aug 11, 2025

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 85.6% 79.8%
Steeltoe.Common.Certificates 96.2% 85.2%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 41.6%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 97.8% 92.6%
Steeltoe.Configuration.CloudFoundry 99.1% 91.6%
Steeltoe.Configuration.ConfigServer 97.2% 91.5%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.4% 95.4%
Steeltoe.Connectors 94.8% 90%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 90.4% 100%
Steeltoe.Discovery.Consul 98% 94.8%
Steeltoe.Discovery.Eureka 92.7% 85.6%
Steeltoe.Discovery.HttpClients 94% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.5% 89.1%
Steeltoe.Management.Prometheus 95.9% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.3% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Aug 11, 2025
@bart-vmware bart-vmware added this to the 4.0.0 milestone Aug 11, 2025
@bart-vmware bart-vmware marked this pull request as ready for review August 13, 2025 13:22
@bart-vmware bart-vmware requested a review from TimHess August 13, 2025 13:22
Copy link

@bart-vmware bart-vmware requested a review from TimHess August 14, 2025 13:47
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great to Me, should be a huge improvement to the experience for anybody needing to upgrade!

@bart-vmware bart-vmware merged commit 667e7a4 into main Aug 15, 2025
27 of 28 checks passed
@bart-vmware bart-vmware deleted the obsoletions-in-v4 branch August 15, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide user guidance about merged packages
2 participants