Skip to content

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Sep 23, 2025

  • Update Config Server, Eureka Server and Spring Boot Admin to Spring Boot 3.5.6
  • Bump Eureka to 4.3.0 (via start.spring.io), SBA to 3.5.5 (via new patch file)
  • Convert .adoc files to .md
  • Use Gradle (plus buildpacks) instead of dockerfiles to build the non-UAA images for easier server development

…ka, sba deps

- also convert all .adoc to .md
@TimHess TimHess requested a review from bart-vmware September 23, 2025 13:59
- use metadata/IMAGE_VERSION as source of truth, also read it in fewer places
- use lazy-initialization in eureka to improve start time
…t version to metadata

- add build.ps1 to workflow triggers
- remove bash script
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried to run anything yet; initial feedback is based on browsing through the diff.

@TimHess TimHess requested a review from bart-vmware September 26, 2025 13:45
Copy link

To run the UAA server image built for this pull request:

docker run --rm -d --pull=always -p 8080:8080 --name uaa-pr steeltoe.azurecr.io/uaa-server:pr-48

Copy link

To run the Spring Boot Admin server image built for this pull request:

docker run --rm -d --pull=always -p 9099:9099 --name sba-pr steeltoe.azurecr.io/spring-boot-admin:pr-48

Copy link

To run the Spring Cloud Config Server image built for this pull request:

docker run --rm -d --pull=always -p 8888:8888 --name config-pr steeltoe.azurecr.io/config-server:pr-48

Copy link

To run the Eureka server image built for this pull request:

docker run --rm -d --pull=always -p 8761:8761 --name eureka-pr steeltoe.azurecr.io/eureka-server:pr-48

Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by the auto-generated comments, I'm running:

docker run --rm -d --pull=always -p 8761:8761 --name eureka-pr steeltoe.azurecr.io/eureka-server:pr-48
docker run --rm -d --pull=always -p 8888:8888 --name config-pr steeltoe.azurecr.io/config-server:pr-48

Which shows the following error:

2025-09-30T11:46:39.448Z  INFO 1 --- [configserver] [           main] com.netflix.discovery.DiscoveryClient    : Getting all instance registry info from the eureka server

2025-09-30T11:46:39.663Z  INFO 1 --- [configserver] [           main] c.n.d.s.t.d.RedirectingEurekaHttpClient  : Request execution error. endpoint=DefaultEndpoint{ serviceUrl='http://localhost:8761/eureka/}, exception=I/O error on GET request for "http://localhost:8761/eureka/apps/": Connect to [http://localhost:8761⁠](http://localhost:8761/) failed: Connection refused stacktrace=org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:8761/eureka/apps/": Connect to [http://localhost:8761⁠](http://localhost:8761/) failed: Connection refused

Can you please verify and confirm that the new containers work with the Steeltoe samples?

I retried by adding -e eureka.client.enabled=true, which doesn't help.

```shell
docker images
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run ./build.ps1 -List, it prints:

Name
----
config-server
config-server-temp
eureka-server
spring-boot-admin
uaa-server

Should the config-server-temp directory be removed after completion of the script?

@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Sep 30, 2025
- Pass a couple more properties to Initializr
- Remove spring.config.name override
- Opt out of cloud native binding support
- Exclude "-temp" folders from supported images list
Copy link

To run the UAA server image built for this pull request:

docker run --rm -d --pull=always -p 8080:8080 --name uaa-pr steeltoe.azurecr.io/uaa-server:pr-48

Copy link

To run the Eureka server image built for this pull request:

docker run --rm -d --pull=always -p 8761:8761 --name eureka-pr steeltoe.azurecr.io/eureka-server:pr-48

Copy link

To run the Spring Cloud Config Server image built for this pull request:

docker run --rm -d --pull=always -p 8888:8888 --name config-pr steeltoe.azurecr.io/config-server:pr-48

Copy link

To run the Spring Boot Admin server image built for this pull request:

docker run --rm -d --pull=always -p 9099:9099 --name sba-pr steeltoe.azurecr.io/spring-boot-admin:pr-48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants