Skip to content

Comments

doc clarify statics may leak#184

Merged
Stebalien merged 3 commits intoStebalien:masterfrom
jtmoon79:master
Jul 15, 2022
Merged

doc clarify statics may leak#184
Stebalien merged 3 commits intoStebalien:masterfrom
jtmoon79:master

Conversation

@jtmoon79
Copy link
Contributor

documentation notes static declared instances may leak (like with
lazy_static). Links to underlying reason
rust-lang-nursery/lazy-static.rs#62

Issue #183

documentation notes static declared instances may leak (like with
lazy_static). Links to underlying reason
rust-lang-nursery/lazy-static.rs#62

Issue #183
Copy link
Owner

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, otherwise LGTM. Thanks!

@jtmoon79
Copy link
Contributor Author

All yours. You may want to squash the PR into the first commit.

replace `then` with `,`

Co-authored-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien merged commit 716e58e into Stebalien:master Jul 15, 2022
@Stebalien
Copy link
Owner

Thanks! Sorry for being so picky on the wording and thanks for your patience.

takumi-earth pushed a commit to earthlings-dev/tempfile that referenced this pull request Jan 27, 2026
documentation notes static declared instances may leak (like with lazy_static). Links to underlying reason
rust-lang-nursery/lazy-static.rs#62

Issue Stebalien#183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants