doc clarify statics may leak#184
Merged
Stebalien merged 3 commits intoStebalien:masterfrom Jul 15, 2022
jtmoon79:master
Merged
Conversation
documentation notes static declared instances may leak (like with lazy_static). Links to underlying reason rust-lang-nursery/lazy-static.rs#62 Issue #183
Stebalien
reviewed
Jul 13, 2022
Owner
Stebalien
left a comment
There was a problem hiding this comment.
nits, otherwise LGTM. Thanks!
Contributor
Author
|
All yours. You may want to squash the PR into the first commit. |
replace `then` with `,` Co-authored-by: Steven Allen <steven@stebalien.com>
Owner
|
Thanks! Sorry for being so picky on the wording and thanks for your patience. |
takumi-earth
pushed a commit
to earthlings-dev/tempfile
that referenced
this pull request
Jan 27, 2026
documentation notes static declared instances may leak (like with lazy_static). Links to underlying reason rust-lang-nursery/lazy-static.rs#62 Issue Stebalien#183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
documentation notes static declared instances may leak (like with
lazy_static). Links to underlying reason
rust-lang-nursery/lazy-static.rs#62
Issue #183