Clean up event system docs #29
Open
+78
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
english5040
requested changes
May 12, 2025
Guide-‐-Event-Manager.md
Outdated
There was a problem hiding this comment.
It might be clearer to directly attribute the old stuff to WilsontheWolf and your new code in this section to yourself
There was a problem hiding this comment.
Overall the first person perspective is weird for a guide, IMO. I don't care about the attribution personally (git blame exists), but I'm not about to strip it out.
There was a problem hiding this comment.
Regarding the first person of this page, (and some other oddities), this guide was originally written as a gist I made personally, then later adopted on the wiki.
|
I can probably do any grammar edits myself if I get the chance |
WilsontheWolf
requested changes
May 18, 2025
english5040
reviewed
May 18, 2025
WilsontheWolf
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this should be a bit clearer, especially with before events.