Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Steam can hang or crash during normal exit or a restart after changing the interface language. Shutdown may run after function-local services have been destroyed, and CDP callbacks can still be waiting for replies from an exiting browser. Plugin IPC threads also write log buffers while MEP clients read them.
Related work
Related to #931. The shutdown lifetime changes and the CDP callback join ordering partially overlap draft #841; this PR brings the tested shutdown work together independently of the macOS restoration, and additionally fixes request registration and logger races. This is not confirmation of the exact cause on the issue reporter's machine.
The per-plugin zombie-reaping delay fix is separate in #937. This PR targets
maindirectly and does not include that change.Validation
main, both return/exit lifecycle cases time out and the blocked-CDP-callback case fails its watchdog; the same cases pass after the fix.-Wall -Wextra -Werror.Millennium unloaded successfullyand no new Steam coredumps. These were combined-package tests, not a new full Steam run from this branch alone.Each suite also runs independently, for example:
Use
tests/cpp/posix_lifecycleortests/cpp/logger_concurrencyfor the other suites.