Skip to content

fix(src/backend/entry_point.cc): Millennium update message showing blank command (#609) #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ninetailedtori wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(src/backend/entry_point.cc): Millennium update message showing blank command (#609) #628

ninetailedtori wants to merge 9 commits into from

Conversation

@ninetailedtori
Copy link
Contributor

@ninetailedtori ninetailedtori commented Jan 7, 2026 •
edited
Loading

Fixes: #609.

Untested rn, and I need info on whether or not these are the correct strings from NixOS. Would welcome testing on this.

@ninetailedtori
This might work?
e5ff092 
Untested rn, and;
I need info on whether or not these are the correct strings from NixOS.

Signed-off-by: Toria <ninetailedtori@uwu.gal>
@ninetailedtori ninetailedtori changed the title fix(src/backend/entry_point.cc): Millennium update message showing blank command #609 fix(src/backend/entry_point.cc): Millennium update message showing blank command (#609) Jan 7, 2026
@ninetailedtori
Add comp to 0.
6af83fd 
Signed-off-by: Toria <ninetailedtori@uwu.gal>
@ninetailedtori
Initialise release_buf struct stat.
875e463 
Signed-off-by: Toria <ninetailedtori@uwu.gal>
@ninetailedtori
Add headers just in case.
3c5c3e7 
Signed-off-by: Toria <ninetailedtori@uwu.gal>
@ninetailedtori ninetailedtori marked this pull request as ready for review January 7, 2026 18:22
@ninetailedtori
Remove unused directive.
8b8f2b5 
Signed-off-by: Toria <ninetailedtori@uwu.gal>
@ninetailedtori
Move showNotifications to destructoring service.
e8179e0 
let, await.

Signed-off-by: Toria <ninetailedtori@uwu.gal>
@shdwmtr
Copy link
Member

shdwmtr commented Jan 7, 2026

We should do it at compile time in cmake. We already have it setup that way. This reduces startup overhead and incorrect detections. For example, if I was on arch, but manually installed (i.e outside of the aur) I would be prompted to use the aur command to update, even though I installed manually.

I'll take a look at it in a couple days likely if we don't get it resolved in the meantime.

@ninetailedtori
Move everything to simple compile-time configuration and pull from CM…
a2cb8ed 
…ake in function.

Signed-off-by: Toria <ninetailedtori@uwu.gal>
@ninetailedtori
Copy link
Contributor Author

ninetailedtori commented Jan 9, 2026

We should do it at compile time in cmake. We already have it setup that way. This reduces startup overhead and incorrect detections. For example, if I was on arch, but manually installed (i.e outside of the aur) I would be prompted to use the aur command to update, even though I installed manually.

I'll take a look at it in a couple days likely if we don't get it resolved in the meantime.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]

2 participants

@ninetailedtori @shdwmtr