Index based series building #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsaarimaa
reviewed
Aug 1, 2024
jsaarimaa
reviewed
Aug 1, 2024
jsaarimaa
reviewed
Aug 1, 2024
jsaarimaa
reviewed
Aug 1, 2024
jsaarimaa
reviewed
Aug 1, 2024
jsaarimaa
reviewed
Aug 2, 2024
jsaarimaa
reviewed
Sep 10, 2024
…for multiselectable variables
…in row or column variables
…tened by a helper function for generating mock responses
sakari-malkki
force-pushed
the
feature/index-based-data-view
branch
from
6487051 to
6c98300
Compare
…ble and multiselectable variables
jsaarimaa
reviewed
Sep 12, 2024
jsaarimaa
reviewed
Sep 12, 2024
jsaarimaa
reviewed
Sep 12, 2024
…ely, add tests for varying preliminary status and precision
|
jsaarimaa
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewUtils.ts buildSeries function changed to create the view based on the data indices of different combinations of included values instead of sequences of selectable values. This supports including row or column variables as selectables.
Had to clear tableChart.ts TABLE_WITH_ROW_AND_COLUMN_VARIABLES fixtures selectedVariableCodes because it was inconsistent with the fixture's selectableVariableCodes causing issues.
TSingleSelections type is now removed since all all selectable value views are handled as one in buildSeries and there's no more need for collapsing selectable selections and combining different views together.