Skip to content

Upgrade Storybook from version 6.5 to 8.1#30

Merged
jsaarimaa merged 1 commit intodevfrom
storybook-upgrade-6-to-8
May 27, 2024
Merged

Upgrade Storybook from version 6.5 to 8.1#30
jsaarimaa merged 1 commit intodevfrom
storybook-upgrade-6-to-8

Conversation

@lehtu
Copy link
Collaborator

@lehtu lehtu commented May 27, 2024

  • ran npx storybook@latest upgrade script
  • removed .npmrc with legacy-peer-deps flag
  • validated with npx storybook doctor
  • converted ./storybook config files to typescript

@sakari-malkki
Copy link
Member

Note, after merging or checking out, running npm ci is required to make storybook commands work

sakari-malkki
sakari-malkki previously approved these changes May 27, 2024
Copy link
Member

@sakari-malkki sakari-malkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the branch, clean installed packages, ran tests, ran storybook and looked through the different fixtures. Everything appears to be working as intended.

CI is failing because version number has not been updated. PR needs another approvement after that.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jsaarimaa jsaarimaa merged commit 897bc1d into dev May 27, 2024
@jsaarimaa jsaarimaa deleted the storybook-upgrade-6-to-8 branch May 27, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants