Skip to content

Conversation

@sakari-malkki
Copy link
Member

This fixes mismatching line spacing between charts and tables

Copilot AI review requested due to automatic review settings December 8, 2025 11:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses inconsistent line spacing between charts and tables by applying uniform CSS styling to table metadata sections. The fix ensures that units, footnotes, last updated dates, and sources in HTML tables have consistent margins matching those used in chart visualizations.

Key Changes:

  • Added a new CSS class tableChart-metadata with zero top and bottom margins to control spacing
  • Applied this class to all metadata paragraph elements in HTML tables (units, footnotes, last updated, sources)
  • Incremented package version from 1.4.1 to 1.4.2

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/react/components/globalStyle/globalStyle.ts Defines the new CSS class for table metadata styling
src/core/tables/htmlTable.ts Applies the CSS class to all metadata paragraph elements
package.json Version bump for the release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 9, 2025 08:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@sakari-malkki sakari-malkki merged commit 25b7797 into dev Dec 9, 2025
8 checks passed
@sakari-malkki sakari-malkki deleted the bugfix/table-metadata-style branch December 9, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants