[Fix] Replace credits field with captions #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2 RC 1
Release 2 RC 2 (1.1.0)
Release 2 RC 3
Release 1.1.2 RC1
Release 1.1.3 RC 1
Release 1.1.4 RC1
Release 1.2.0 RC 1
Release 10 RC 1
Release v.1.2.2
Release v1.2.4 RC 1
Release v1.3.0 RC1
Release v1.3.2 RC 1
Release v1.4.0 RC1
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Highcharts credits field with captions to provide more flexible and responsive chart attribution. The change applies a more standard approach to displaying source information and last updated timestamps.
Key Changes:
- Replaced
creditsconfiguration withcaptionfield throughout the codebase - Simplified chart options logic by removing complex conditional
creditspositioning - Updated accessibility configuration to include caption translations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core/highcharts/themes.ts | Added caption accessibility translation and changed credits config to caption |
| src/core/chartOptions/chartOptions.ts | Replaced credits field with caption, removed complex positioning logic |
| src/core/conversion/pxGrafDataConverter.test.ts | Updated test assertions from credits.text to caption.text |
| src/stories/chartstories/linechart.stories.tsx | Added new story variant demonstrating caption with last updated information |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
jsaarimaa
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More flexible and repsonsive