[Fix] Rename showTitle back to showTitles #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een code and documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a naming discrepancy by renaming the showTitle property back to showTitles throughout the codebase to align with documentation.
- Renamed
showTitletoshowTitlesin interface definitions, component props, and all usage locations - Updated test files to use the corrected property name
- Ensured consistency between code implementation and documentation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/types/chartOptions.ts | Updated interface definition to use showTitles |
| src/react/components/chart/chart.tsx | Updated component prop definition and usage |
| src/core/tables/htmlTable.ts | Updated property access in table rendering logic |
| src/core/chartOptions/chartOptions.ts | Updated variable name and property access |
| src/react/components/chart/tableView.test.tsx | Updated test to use correct property name |
| src/react/components/chart/chart.test.tsx | Updated test props to use correct property name |
| src/core/tables/htmlTable.test.ts | Updated test configurations to use correct property name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
jsaarimaa
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes discrepancy between code and documentation