Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qr code to insights->about->tor #2379

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

Reckless-Satoshi
Copy link
Contributor

This PR adds a QR scan button to Insights -> About -> Tor onion property.

Scanning the QR codes is very handy for the apps. However, I did not find where to scan the main startos entrypoint QR.

This PR is not tested, I have no experience with Angular/Ionic and just edited code without setting up a dev environment . Hopefully it is not far from working.

Copy link
Member

@elvece elvece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a few changes to get it working but works great once fixed!

@@ -2,6 +2,7 @@ import { ChangeDetectionStrategy, Component } from '@angular/core'
import { ToastController } from '@ionic/angular'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { ToastController } from '@ionic/angular'
import { ModalController, ToastController } from '@ionic/angular'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot comment on the direct line, but you also need to add the following to the class constructor:

private readonly modalCtrl: ModalController,

so its finalized form should look like:

  constructor(
    private readonly toastCtrl: ToastController,
    private readonly modalCtrl: ModalController,
    private readonly patch: PatchDB<DataModel>,
    private readonly config: ConfigService,
  ) {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @elvece thank you for testing it so quickly! 🚀 Committed the fix.

@elvece elvece merged commit 32ca91a into Start9Labs:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants