Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to https:// urls for repositories, remove apt-transport-https #1610

Merged

Conversation

gStart9
Copy link
Member

@gStart9 gStart9 commented Jul 3, 2022

As of apt 1.5, the package apt-transport-https is no longer required because https:// is supported out of the box.
Reference: https://packages.debian.org/bullseye/apt-transport-https "This is a dummy transitional package - https support has been moved into the apt package in 1.5. It can be safely removed." Apt is currently at 2.2.4.

Use a sed one-liner to convert all repos in /etc/apt/sources.list and /etc/apt/sources.list.d/*.list that are http:// to https:// (https:// is available for all http:// URLs currently referenced in EmbassyOS's apt repos).

As of apt 1.5 (released 2017), the package apt-transport-https is no longer required because https:// is supported out of the box.
Reference: https://packages.debian.org/bullseye/apt-transport-https "This is a dummy transitional package - https support has been moved into the apt package in 1.5. It can be safely removed."  Apt is currently at 2.2.4.

Use a sed one-liner to convert all repos in /etc/apt/sources.list and /etc/apt/sources.list.d/*.list that are http:// to https:// (https:// is available for all http:// URLs currently referenced in EmbassyOS).
@gStart9 gStart9 requested a review from dr-bonez July 3, 2022 19:23
@elvece
Copy link
Member

elvece commented Jul 4, 2022

@gStart9 Has this been tested by running a fresh image after building from source?

@gStart9
Copy link
Member Author

gStart9 commented Jul 4, 2022

@elvece no it has not. I will try to do that tonight.

@elvece
Copy link
Member

elvece commented Jul 4, 2022

@elvece no it has not. I will try to do that tonight.

Great - post results back here and we will get merged on success.

@dr-bonez dr-bonez merged commit b365a60 into master Jul 5, 2022
@dr-bonez dr-bonez deleted the initialization.sh-update-repos_to_https_by_default branch July 11, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants