Fix/sideload icon type #1577
Merged
Fix/sideload icon type #1577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvece
added
Enhancement
Blu-J
reviewed
Jun 27, 2022
frontend/projects/ui/src/app/pages/server-routes/sideload/sideload.page.ts
Outdated
Show resolved
Hide resolved
Blu-J
reviewed
Jun 27, 2022
frontend/projects/ui/src/app/pages/server-routes/sideload/sideload.page.ts
Outdated
Show resolved
Hide resolved
Blu-J
previously approved these changes
Jun 27, 2022
MattDHill
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main task here was to add the content type for icons.
Ended up refactoring how I was handling reading blobs to array buffers or data urls, so as to avoid using
astypecasting. I wanted to accurately handle the error cases, so added proper logic to do so.Tested via proxy to live backend.