Feature/require script consistency #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProofOfKeags
force-pushed
the
feature/require-script-consistency
branch
from
a7e768e to
93033e4
Compare
wip: Getting async js feat: Have execute get action config feat: Read + Write chore: Add typing for globals chore: Change the default path, include error on missing function, and add json File Read Write chore: Change the default path, include error on missing function, and add json File Read Write wip: Fix the unit test wip: Fix the unit test feat: module loading
ProofOfKeags
force-pushed
the
feature/require-script-consistency
branch
from
93033e4 to
238c1c6
Compare
ProofOfKeags
added
Enhancement
Blu-J
reviewed
May 27, 2022
| @@ -8,7 +8,7 @@ if [ "$0" != "./build-prod.sh" ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| alias 'rust-arm64-builder'='docker run --rm -it -v "$HOME/.cargo/registry":/root/.cargo/registry -v "$(pwd)":/home/rust/src start9/rust-arm-cross:aarch64' | |||
| alias 'rust-arm64-builder'='docker run --rm -it -v "$HOME/.cargo/registry":/root/.cargo/registry -v "$(pwd)":/home/rust/src -P start9/rust-arm-cross:aarch64' | |||
Blu-J
reviewed
May 27, 2022
| @@ -154,6 +154,29 @@ pub struct Manifest { | |||
| pub dependencies: Dependencies, | |||
| } | |||
|
|
|||
| impl Manifest { | |||
| pub fn package_procedures(&self) -> impl Iterator<Item = &PackageProcedure> { | |||
There was a problem hiding this comment.
💬 I don't like the looks of this but there are no working solutions. I think that a generator syntax would work better.
Blu-J
reviewed
May 27, 2022
| None | ||
| let needs_script = manifest.package_procedures().any(|a| a.is_script()); | ||
| let has_script = script_path.exists(); | ||
| match (needs_script, has_script) { |
There was a problem hiding this comment.
🤔 Neat. I kinda like this pattern, but if we got more than two, maybe having enums to try and prevent boolean blindness?
match (needs_script, has_script) {
(AreScripts, HasScripts) => ...,
(AreScript, MissingScripts) => ...,
(NoScripts, HasScripts) => ...,
(NoScripts, MissingScripts) => None,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #1437