Skip to content

Comments

[pull] main from spring-projects:main#6

Merged
pull[bot] merged 1 commit intoStars1233:mainfrom
spring-projects:main
May 6, 2025
Merged

[pull] main from spring-projects:main#6
pull[bot] merged 1 commit intoStars1233:mainfrom
spring-projects:main

Conversation

@pull
Copy link

@pull pull bot commented May 6, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label May 6, 2025
@pull pull bot merged commit 46d42ab into Stars1233:main May 6, 2025
@gitstream-cm
Copy link

gitstream-cm bot commented May 6, 2025

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 853/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

@sourcery-ai
Copy link

sourcery-ai bot commented May 6, 2025

Reviewer's Guide

This PR deprecates JobRepositoryFactoryBean in favor of the new JdbcJobRepositoryFactoryBean for JDBC-based configurations. The implementation involved annotating JobRepositoryFactoryBean as deprecated, changing its field visibility to protected, creating JdbcJobRepositoryFactoryBean as a subclass, and updating all references (Java code, XML configurations, tests, and Javadoc) from the old to the new factory bean. Documentation was also updated.

Class Diagram: Refactoring of JobRepositoryFactoryBean and Introduction of JdbcJobRepositoryFactoryBean

classDiagram
  direction LR

  class AbstractJobRepositoryFactoryBean {
    %% Base class, Javadoc updated in PR
  }
  note for AbstractJobRepositoryFactoryBean "Referenced in Javadoc updates of this class."

  class InitializingBean {
    <<Interface>>
    +afterPropertiesSet() void
  }

  class JobRepositoryFactoryBean {
    <<Deprecated>>
    #dataSource: DataSource
    #jdbcOperations: JdbcOperations
    #databaseType: String
    #tablePrefix: String
    #incrementerFactory: DataFieldMaxValueIncrementerFactory
    #jobKeyGenerator: JobKeyGenerator
    #maxVarCharLengthForExitMessage: int
    #maxVarCharLengthForShortContext: int
    #serializer: ExecutionContextSerializer
    #clobType: Integer
    #charset: Charset
    #conversionService: ConfigurableConversionService
    +JobRepositoryFactoryBean()
    %% Methods like setters for these fields exist
    %% but are not shown for brevity as their signatures didn't change.
  }
  note for JobRepositoryFactoryBean "Deprecated in 6.0 (forRemoval=true).\nAll instance fields changed from private to protected."

  class JdbcJobRepositoryFactoryBean {
    +JdbcJobRepositoryFactoryBean()
  }
  note for JdbcJobRepositoryFactoryBean "Introduced in 6.0.\nNew factory bean for JDBC-based JobRepository."

  AbstractJobRepositoryFactoryBean <|-- JobRepositoryFactoryBean
  JobRepositoryFactoryBean <|-- JdbcJobRepositoryFactoryBean
  JobRepositoryFactoryBean ..|> InitializingBean
Loading

File-Level Changes

Change Details Files
Deprecated JobRepositoryFactoryBean and modified its field visibility for inheritance.
  • Added @Deprecated(since = "6.0", forRemoval = true) annotation to the class.
  • Updated class Javadoc to indicate deprecation and recommend JdbcJobRepositoryFactoryBean.
  • Changed visibility of all instance fields from private to protected.
spring-batch-core/src/main/java/org/springframework/batch/core/repository/support/JobRepositoryFactoryBean.java
Introduced JdbcJobRepositoryFactoryBean as a direct subclass of JobRepositoryFactoryBean.
  • Created new public class JdbcJobRepositoryFactoryBean that extends JobRepositoryFactoryBean.
spring-batch-core/src/main/java/org/springframework/batch/core/repository/support/JdbcJobRepositoryFactoryBean.java
Replaced usages of JobRepositoryFactoryBean with JdbcJobRepositoryFactoryBean in Java source and test files.
  • Updated direct instantiations and type references from JobRepositoryFactoryBean to JdbcJobRepositoryFactoryBean.
  • Modified bean definition builders and Javadoc comments to use/refer to JdbcJobRepositoryFactoryBean.
spring-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/JobRepositoryParser.java
spring-batch-core/src/main/java/org/springframework/batch/core/configuration/annotation/BatchRegistrar.java
spring-batch-core/src/main/java/org/springframework/batch/core/configuration/support/DefaultBatchConfiguration.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/ExtendedAbstractJobTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/SimpleJobFailureTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/SimpleJobTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/SimpleStepHandlerTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/builder/FlowJobBuilderTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/flow/FlowJobFailureTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/flow/FlowJobTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/job/flow/FlowStepTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/partition/support/PartitionStepTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/partition/support/RemoteStepExecutionAggregatorTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/partition/support/SimpleStepExecutionSplitterTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/builder/StepBuilderTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantStepFactoryBeanRetryTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantStepFactoryBeanRollbackTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantStepFactoryBeanTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantStepFactoryBeanUnexpectedRollbackTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/SimpleStepFactoryBeanTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/job/JobStepTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/tasklet/StepExecutorInterruptionTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/step/tasklet/TaskletStepTests.java
spring-batch-core/src/test/java/org/springframework/batch/core/test/concurrent/ConcurrentTransactionTests.java
spring-batch-integration/src/test/java/org/springframework/batch/integration/chunk/ChunkMessageItemWriterIntegrationTests.java
Replaced JobRepositoryFactoryBean with JdbcJobRepositoryFactoryBean in XML configuration files.
  • Updated the class attribute in bean definitions from org.springframework.batch.core.repository.support.JobRepositoryFactoryBean to org.springframework.batch.core.repository.support.JdbcJobRepositoryFactoryBean.
spring-batch-core/src/test/resources/org/springframework/batch/core/partition/launch-context.xml
spring-batch-core/src/test/resources/org/springframework/batch/core/repository/dao/TablePrefixTests-context.xml
spring-batch-core/src/test/resources/org/springframework/batch/core/repository/support/SimpleJobRepositoryProxyTests-context.xml
spring-batch-core/src/test/resources/simple-job-launcher-context.xml
spring-batch-samples/src/main/resources/org/springframework/batch/samples/jpa/job/jpa.xml
spring-batch-samples/src/main/resources/org/springframework/batch/samples/jpa/job/repository.xml
spring-batch-samples/src/main/resources/org/springframework/batch/samples/misc/jmx/adhoc-job-launcher-context.xml
spring-batch-samples/src/main/resources/org/springframework/batch/samples/skip/job/skipSample-job-launcher-context.xml
spring-batch-samples/src/main/resources/simple-job-launcher-context.xml
spring-batch-test/src/test/resources/simple-job-launcher-context.xml
Updated Javadoc references in related classes and documentation files.
  • Updated Javadoc in AbstractJobRepositoryFactoryBean to reference JdbcJobRepositoryFactoryBean and MongoJobRepositoryFactoryBean.
  • Updated copyright year to 2025 in AbstractJobRepositoryFactoryBean.java.
  • Modified the configuring-repository.adoc documentation file to reflect the new factory bean.
spring-batch-core/src/main/java/org/springframework/batch/core/repository/support/AbstractJobRepositoryFactoryBean.java
spring-batch-docs/modules/ROOT/pages/job/configuring-repository.adoc

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link

coderabbitai bot commented May 6, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant