Skip to content

[pull] main from apache:main#36

Merged
pull[bot] merged 3 commits intoStars1233:mainfrom
apache:main
Apr 21, 2025
Merged

[pull] main from apache:main#36
pull[bot] merged 3 commits intoStars1233:mainfrom
apache:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Apr 21, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Enhance Join operator in DataFusion with a new try_new method that automatically computes join schemas and supports various join types and constraints

New Features:

  • Add a new try_new method for Join that automatically computes schema based on join type and input plans
  • Implement comprehensive schema computation for different join types including Left, Right, Full, Semi, Anti, and Mark joins

Enhancements:

  • Improve join schema generation logic to handle nullable columns based on join type
  • Add support for complex join conditions with equi-join and filter expressions
  • Enhance join constraint handling for USING and ON join types

Tests:

  • Add extensive test coverage for new Join constructor
  • Validate schema generation for different join types and constraints
  • Test null equality and column nullability behavior

Chores:

  • Update Cargo.lock and Cargo.toml dependencies
  • Refactor join creation methods in LogicalPlanBuilder to use new try_new method

zhuqi-lucas and others added 3 commits April 21, 2025 17:21
Bumps [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) from 0.28.0 to 0.28.1.
- [Release notes](https://github.com/risinglightdb/sqllogictest-rs/releases)
- [Changelog](https://github.com/risinglightdb/sqllogictest-rs/blob/main/CHANGELOG.md)
- [Commits](risinglightdb/sqllogictest-rs@v0.28.0...v0.28.1)

---
updated-dependencies:
- dependency-name: sqllogictest
  dependency-version: 0.28.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pull pull bot added the ⤵️ pull label Apr 21, 2025
@pull pull bot merged commit 9730404 into Stars1233:main Apr 21, 2025
@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Apr 21, 2025

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 7694/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 21, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new try_new constructor for the Join operator that automatically computes the schema based on the join type and inputs. It also updates the LogicalPlanBuilder to use the new constructor and adds comprehensive unit tests. Additionally, it removes a redundant limit check in pushdown_limit_helper function and updates the sqllogictest dependency version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Introduces a new try_new constructor for the Join operator that automatically computes the schema based on the join type and inputs.
  • Adds a try_new function to the Join struct.
  • The try_new function computes the schema based on the join type and inputs.
  • The try_new function returns a Result<Self>.
  • The try_new function takes left, right, on, filter, join_type, join_constraint, and null_equals_null as arguments.
  • The try_new function calls build_join_schema to compute the schema.
  • The try_new function creates a new Join struct with the computed schema.
datafusion/expr/src/logical_plan/plan.rs
Updates the LogicalPlanBuilder to use the new Join::try_new constructor.
  • Replaces the manual construction of the Join struct with a call to Join::try_new in using_join.
  • Replaces the manual construction of the Join struct with a call to Join::try_new in cross_join.
  • Replaces the manual construction of the Join struct with a call to Join::try_new in join_with_expr_keys.
datafusion/expr/src/logical_plan/builder.rs
Adds comprehensive unit tests for the new Join::try_new constructor, covering various join types, constraints, and schema validation scenarios.
  • Adds a test_join_try_new function to test different join types.
  • Adds a test_join_try_new_with_using_constraint_and_overlapping_columns function to test the USING constraint.
  • Adds a test_join_try_new_schema_validation function to test schema validation.
datafusion/expr/src/logical_plan/plan.rs
Removes redundant limit check in pushdown_limit_helper function.
  • Removes the conditional check for existing limits on child nodes before setting global_state.satisfied = true.
datafusion/physical-optimizer/src/limit_pushdown.rs
Updates the sqllogictest dependency version.
  • Updates the sqllogictest dependency from version 0.28.0 to 0.28.1.
datafusion/sqllogictest/Cargo.toml
Cargo.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 21, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants