使用Vuex替代globalData #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 8, 2019 16:02
- 在store文件夹下添加了基本Vuex，已经可以正常使用了 - 在commons文件夹下添加了api.ts，借鉴了apps/Promisify.ts。为了使用Vuex，应该尽快 更换为使用api.ts里的ApiService。
Starrah
requested changes
Nov 14, 2019
| } | ||
|
|
||
| async request(method: "GET" | "POST" | "PUT" | "DELETE", resource: string, param: object = {}) { | ||
| let res = await new Promise((resolve, reject) => { |
frontend/src/commons/api.ts
Outdated
| }); | ||
| let code = res["statusCode"]; | ||
| if (code >= 400) throw Error(code); | ||
| return res["data"]; |
There was a problem hiding this comment.
可以考虑把原来promisify里的在errid5xx时showToast加进来？
之后就不用那个promisify了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
前端开发公共事项 #14 中，第三个 Comment 提到了globalData。在 Issue #30 中，阐述了 globalData 的弊端。为此，本 PR 新建了 src/store/文件夹，计划使用 Vuex 替代 globalData。
此外，在 src/commons 文件夹下添加了
api.ts，借鉴了Promisify.ts。为了搭配使用 Vuex，请将 Promisify 更换为使用api.ts里的 ApiService。