Skip to content

Conversation

@carlos8f
Copy link
Contributor

No description provided.

@carlos8f
Copy link
Contributor Author

benchmark:

before patch

before

after patch

after

@warpech
Copy link
Collaborator

warpech commented Oct 10, 2013

Thanks @carlos8f for a greatly prepared pull reuest. I will merge it with the source

@Starcounter-Jack can you remind what was the reason for ~1, ~0 stuff in first place? Those were some special triggers, I suppose? Maybe it just can be removed now.

@carlos8f
Copy link
Contributor Author

@warpech ~0 and ~1 are the escaped (literal) versions of ~ and /, respectively, according to the JSON pointer spec.

@warpech
Copy link
Collaborator

warpech commented Oct 10, 2013

Ah, I oversaw it... So apply takes escaping in consideration (though fails on multiple escaped characters), while generate does not consider them at all

@carlos8f
Copy link
Contributor Author

correct :)

@warpech warpech merged commit 82dc572 into Starcounter-Jack:master Oct 11, 2013
@warpech
Copy link
Collaborator

warpech commented Oct 11, 2013

Thanks, I included your fix in v0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants