Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lake] Support lake tablet statistic collection #9460

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Aug 2, 2022

What type of PR is this:

  • bug
  • feature
  • enhancement
  • refactor
  • others

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

FE periodically collect lake tablet statistic, such as num rows and data size.
Num rows statistic is used in CBO optimizer.

kevincai
kevincai previously approved these changes Aug 2, 2022
@wyb
Copy link
Contributor Author

wyb commented Aug 2, 2022

run starrocks_fe_unittest

FE periodically collect lake tablet statistic, such as num rows and data size.
Num rows statistic is used in CBO optimizer.
@wyb wyb force-pushed the lake_tablet_stat branch from f1621f5 to 64e41fb Compare August 2, 2022 12:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 99 / 129 (76.74%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/lake/Utils.java 0 1 00.00% [34]
🔵 com/starrocks/rpc/LakeServiceClient.java 0 4 00.00% [72, 73, 74, 75]
🔵 com/starrocks/catalog/TabletStatMgr.java 99 124 79.84% [123, 125, 126, 128, 129, 130, 132, 133, 135, 138, 171, 179, 187, 188, 204, 212, 226, 238, 260, 261, 262, 268, 277, 285, 286]

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Aug 4, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@wyb wyb merged commit 1f344cd into StarRocks:main Aug 4, 2022
amorynan pushed a commit to amorynan/starrocks that referenced this pull request Aug 5, 2022
1. FE periodically collect lake tablet statistic, such as num rows and data size.
2. Num rows statistic is used in CBO optimizer.
3. Data size statistic is used in show command, like show data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants