[Refactor] Removed not used log upon start and unified drop_tablet_unlock interface #9318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock interface Many logs upon start is non-sense and the pull request remove these logs. The AlterTask is already not used and drop_tablet_unlocked can be unified.
trueeyu
approved these changes
Jul 29, 2022
decster
approved these changes
Jul 29, 2022
|
run starrocks_admit_test |
1 similar comment
|
run starrocks_admit_test |
9 tasks
imay
pushed a commit
that referenced
this pull request
Oct 25, 2022
Fixes a typo in the log introduced by #9318, and changed a log output location for better debugging in BE * Fixed the log output for BE IP: `backend_options.cpp:77] local host192.168.145.1` * Moved the log about a mismatched BE IP address into the WARNING log, instead of INFO, for a better debugging experience. ``` I1024 15:36:38.188383 248318 heartbeat_server.cpp:148] 172.17.0.1 not equal to to backend localhost 192.168.145.1 W1024 15:36:38.188386 248318 heartbeat_server.cpp:74] Fail to handle heartbeat: Internal error: FE saved address not match backend address cached master info: TMasterInfo(network_address=TNetworkAddress(hostname=, port=0), cluster_id=-1, epoch=0, token=<null>, backend_ip=<null>, http_port=<null>, heartbeat_flags=<null>, backend_id=<null>) received master info: TMasterInfo(network_address=TNetworkAddress(hostname=172.17.0.1, port=9020), cluster_id=452026703, epoch=3, token=c2de331e-6628-4f77-92cc-913a61aa40f8, backend_ip=172.17.0.1, http_port=8030, heartbeat_flags=0, backend_id=10020) ```
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
Fixes a typo in the log introduced by #9318, and changed a log output location for better debugging in BE * Fixed the log output for BE IP: `backend_options.cpp:77] local host192.168.145.1` * Moved the log about a mismatched BE IP address into the WARNING log, instead of INFO, for a better debugging experience. ``` I1024 15:36:38.188383 248318 heartbeat_server.cpp:148] 172.17.0.1 not equal to to backend localhost 192.168.145.1 W1024 15:36:38.188386 248318 heartbeat_server.cpp:74] Fail to handle heartbeat: Internal error: FE saved address not match backend address cached master info: TMasterInfo(network_address=TNetworkAddress(hostname=, port=0), cluster_id=-1, epoch=0, token=<null>, backend_ip=<null>, http_port=<null>, heartbeat_flags=<null>, backend_id=<null>) received master info: TMasterInfo(network_address=TNetworkAddress(hostname=172.17.0.1, port=9020), cluster_id=452026703, epoch=3, token=c2de331e-6628-4f77-92cc-913a61aa40f8, backend_ip=172.17.0.1, http_port=8030, heartbeat_flags=0, backend_id=10020) ``` (cherry picked from commit d817f3d)
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 26, 2022
Fixes a typo in the log introduced by #9318, and changed a log output location for better debugging in BE * Fixed the log output for BE IP: `backend_options.cpp:77] local host192.168.145.1` * Moved the log about a mismatched BE IP address into the WARNING log, instead of INFO, for a better debugging experience. ``` I1024 15:36:38.188383 248318 heartbeat_server.cpp:148] 172.17.0.1 not equal to to backend localhost 192.168.145.1 W1024 15:36:38.188386 248318 heartbeat_server.cpp:74] Fail to handle heartbeat: Internal error: FE saved address not match backend address cached master info: TMasterInfo(network_address=TNetworkAddress(hostname=, port=0), cluster_id=-1, epoch=0, token=<null>, backend_ip=<null>, http_port=<null>, heartbeat_flags=<null>, backend_id=<null>) received master info: TMasterInfo(network_address=TNetworkAddress(hostname=172.17.0.1, port=9020), cluster_id=452026703, epoch=3, token=c2de331e-6628-4f77-92cc-913a61aa40f8, backend_ip=172.17.0.1, http_port=8030, heartbeat_flags=0, backend_id=10020) ``` (cherry picked from commit d817f3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many logs upon start are non-sense, and the pull request removes these logs.
The AlterTask is already not used, and drop_tablet_unlocked can be unified.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：