Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] optimize aggregate function window_funnel #9247

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Jul 26, 2022

What type of PR is this:

  • bug
  • feature
  • enhancement
  • refactor
  • others

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

  1. reduce memory alloc by PMR (alloc by stack)
  2. reduce some function call (ArrayColumn::offsets/elements)
  3. reduce some virtual function call (eg: append(DatumArray))

case:

mysql> select level, count(*) uv from  (     select lo_orderkey, window_funnel(3600000, lo_orderdate, 0, [lo_linenumber=1, lo_linenumber=2]) as level      from lineorder      group by lo_orderkey ) AS x  group by level;

16 core for each BE

baseline (sec) patched (sec)
colocate one stage AGG (1FE 3BE) 9.36 5.33
one stage AGG (1FE 4BE) 8.77 5.74
two stage AGG (1FE 4BE) 14.65 7.11

stdpain added 4 commits July 26, 2022 21:21
1. reduce memory alloc by PMR (alloc by stack)
2. reduce some function call (ArrayColumn::offsets/elements)
3. reduce some virtual function call (eg: append(DatumArray))
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Jul 28, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@stdpain stdpain merged commit bdf63ae into StarRocks:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants