Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support select into outfile without broker #9201

Merged
merged 1 commit into from
Aug 3, 2022
Merged

[Feature] Support select into outfile without broker #9201

merged 1 commit into from
Aug 3, 2022

Conversation

xiaoyong-z
Copy link
Contributor

What type of PR is this：

  • bug
  • feature
  • enhancement
  • refactor
  • others

Which issues of this PR fixes ：

Fixes #9200

Problem Summary(Required) ：

Support select xxx into outfile without broker

chaoyli
chaoyli reviewed Jul 27, 2022
View reviewed changes
be/src/fs/fs.cpp Outdated Show resolved Hide resolved
be/src/fs/fs.cpp Outdated Show resolved Hide resolved
be/src/fs/fs_hdfs.cpp Outdated Show resolved Hide resolved
@xiaoyong-z xiaoyong-z force-pushed the remore-broker-for-insert-into-outfile branch 5 times, most recently from 687242b to 331a3ae Compare August 2, 2022 14:28
@xiaoyong-z
Copy link
Contributor Author

run starrocks_fe_unittest

@xiaoyong-z
Copy link
Contributor Author

run starrocks_be_unittest

@xiaoyong-z
Copy link
Contributor Author

run starrocks_fe_unittest

chaoyli
chaoyli previously approved these changes Aug 3, 2022
View reviewed changes
@xiaoyong-z
[Feature] Support select *** into outfile without broker
87927b4 
Signed-off-by: xyz <a997647204@gmail.com>
@xiaoyong-z xiaoyong-z force-pushed the remore-broker-for-insert-into-outfile branch from 331a3ae to 87927b4 Compare August 3, 2022 05:06
@xiaoyong-z xiaoyong-z requested review from meegoo and chaoyli August 3, 2022 05:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chaoyli chaoyli changed the title [Feature] Support select xxx into outfile without broker [Feature] Support select into outfile without broker Aug 3, 2022
@xiaoyong-z
Copy link
Contributor Author

run starrocks_admit_test

1 similar comment
@xiaoyong-z
Copy link
Contributor Author

run starrocks_admit_test

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Aug 3, 2022
@chaoyli chaoyli merged commit dab0ef7 into StarRocks:main Aug 3, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 8 / 24 (33.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/ResultSink.java 0 1 00.00% [87]
🔵 com/starrocks/analysis/OutFileClause.java 8 23 34.78% [165, 166, 168, 189, 225, 226, 227, 228, 230, 231, 232, 233, 234, 235, 236]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meegoo meegoo meegoo approved these changes

@Astralidea Astralidea Astralidea approved these changes

@chaoyli chaoyli chaoyli approved these changes

Assignees
No one assigned
Labels
Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support select xxx into outfile without broker
5 participants
@xiaoyong-z @wanpengfei-git @meegoo @Astralidea @chaoyli