-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Rank topn prune redundant rows #8108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
670a7b1
to
aabed87
Compare
5b02071
to
92ce23f
Compare
murphyatwork
requested changes
Jul 1, 2022
Pslydhh
previously approved these changes
Jul 1, 2022
murphyatwork
previously approved these changes
Jul 1, 2022
kangkaisen
reviewed
Jul 1, 2022
kangkaisen
reviewed
Jul 1, 2022
kangkaisen
reviewed
Jul 1, 2022
kangkaisen
reviewed
Jul 1, 2022
murphyatwork
previously approved these changes
Jul 4, 2022
murphyatwork
approved these changes
Jul 4, 2022
kangkaisen
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Fixes #5885
Enhancement
In previous work #6120, I support rank topn. Comparing to normal topn, rank-topn should take equal range into consideration, but the result is not well-processed, it's result may contain more rows than we need.
For example, given input
(1 2 3 3 3 4 5)
withlimit=3
, the expected output should be(1 2 3 3 3)
, but the actual result may be(1 2 3 3 3)
、(1 2 3 3 3 4)
、(1 2 3 3 3 4 5)
, which has the prefix of the expected result and with redundant elements.Although it's result is not correct, the plan still works fine, because the late full sort and filter will get the correct results.
In this pr, I add pruning mechanism to remove the redundant rows
Change list