Skip to content

[Refactor] refactor complex_column_reader on variant type#70106

Open
dirtysalt wants to merge 6 commits intoStarRocks:mainfrom
dirtysalt:parquet-shredding-varaint-refactor
Open

[Refactor] refactor complex_column_reader on variant type#70106
dirtysalt wants to merge 6 commits intoStarRocks:mainfrom
dirtysalt:parquet-shredding-varaint-refactor

Conversation

@dirtysalt
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

Signed-off-by: yan zhang <dirtysalt1987@gmail.com>
Signed-off-by: yan zhang <dirtysalt1987@gmail.com>
Signed-off-by: yan zhang <dirtysalt1987@gmail.com>
Signed-off-by: yan zhang <dirtysalt1987@gmail.com>
Signed-off-by: yan zhang <dirtysalt1987@gmail.com>
@dirtysalt dirtysalt requested a review from a team as a code owner March 11, 2026 04:48
@CelerData-Reviewer
Copy link

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7ba525b9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: yan zhang <dirtysalt1987@gmail.com>
@dirtysalt dirtysalt requested a review from a team as a code owner March 11, 2026 10:35
@github-actions
Copy link
Contributor

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions
Copy link
Contributor

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions
Copy link
Contributor

[BE Incremental Coverage Report]

fail : 164 / 248 (66.13%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/parquet/complex_column_reader.cpp 150 231 64.94% [815, 823, 824, 826, 896, 897, 898, 951, 952, 991, 994, 995, 1005, 1006, 1024, 1025, 1043, 1053, 1062, 1063, 1078, 1089, 1090, 1114, 1269, 1283, 1284, 1285, 1290, 1291, 1293, 1310, 1311, 1313, 1362, 1363, 1377, 1391, 1392, 1399, 1402, 1403, 1404, 1405, 1406, 1408, 1409, 1414, 1415, 1420, 1421, 1424, 1486, 1512, 1535, 1536, 1537, 1539, 1540, 1541, 1543, 1587, 1593, 1603, 1640, 1641, 1642, 1644, 1647, 1648, 1649, 1651, 1652, 1653, 1654, 1655, 1656, 1657, 1658, 1668, 1670]
🔵 be/src/formats/parquet/column_reader_factory.cpp 9 12 75.00% [504, 505, 506]
🔵 be/src/formats/parquet/complex_column_reader.h 5 5 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants