Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 21, 2025

Why I'm doing:

What I'm doing:

bump arrow to support parquet legacy encoding nested list.
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#backward-compatibility-rules

// array<array<int>>
optional group a (LIST) {
    repeated group array (LIST) {
      repeated int32 array;
    }
  }

supported in arrow apache/arrow#43995

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

Note

Upgrades Arrow to 19.0.1 with new/updated patches and extends Parquet legacy list tests to include nested/complex files with targeted reads.

  • Third-party/Deps:
    • Upgrade Arrow to 19.0.1 in thirdparty/vars.sh.
    • Update patch flow in thirdparty/download-thirdparty.sh for arrow-apache-arrow-19.0.1.
    • Add patches: thirdparty/patches/arrow-19.0.1-parquet-map-key.patch, thirdparty/patches/arrow-19.0.1-flight-types-clang.patch, and use arrow-19.0.1-use-zstd-1.5.7.patch.
    • Remove obsolete Arrow 5.0.0/16.1.0 patch references.
  • Tests (SQL):
    • Add files list_legacy_encoding_nested.parquet and list_legacy_encoding_complex.parquet to OSS setup.
    • Switch wildcard paths to specific file reads; add schema checks and expected results:
      • Validate nested list schema and sample row for list_legacy_encoding_nested.parquet.
      • Validate struct with lists and map for list_legacy_encoding_complex.parquet and assert counts.
      • Add explicit count for list_legacy_encoding.parquet.

Written by Cursor Bugbot for commit 854beb8. This will update automatically on new commits. Configure here.


This is an automatic backport of pull request #64238 done by [Mergify](https://mergify.com).

Signed-off-by: wyb <wybb86@gmail.com>
(cherry picked from commit d980cb0)
@mergify mergify bot mentioned this pull request Oct 21, 2025
23 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 21, 2025 08:03
@wanpengfei-git wanpengfei-git merged commit 256935c into branch-3.5 Oct 21, 2025
37 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.5/pr-64238 branch October 21, 2025 10:01
@mergify
Copy link
Contributor Author

mergify bot commented Oct 21, 2025

🧪 CI Insights

Here's what we observed from your CI run for 57d459a.

🟢 All jobs passed!

But CI Insights is watching 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants