[Refactor] Refactor GlobalStateMgr #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run starrocks_fe_unittest |
stephen-shelby
changed the title
Astralidea
reviewed
May 19, 2022
|
run starrocks_fe_unittest |
Astralidea
approved these changes
May 19, 2022
caneGuy
approved these changes
May 19, 2022
| result.add(frontend); | ||
| } | ||
| } | ||
| private LocalMetastore localMetastore; |
There was a problem hiding this comment.
nit: how about moving this into metadatamgr?
There was a problem hiding this comment.
This global instance is used in this stage, and the usage method will be uniformly rectified later
gengjun-git
reviewed
May 19, 2022
[FE PR Coverage check]😞 fail : 41 / 310 (13.23%) file detail
|
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 22, 2022
Goals: - Refactoring GlobalStateMgr (the original Fe catalog) is to prepare for building the connector framework. - Reduce globalstatemgr redundant code, The original code is reduced from 8000 lines to 3000 lines. Most of the code in globalstatemgr is transferred to three parts: - NodeMgr: It is mainly used to manage Fe/Be/Broker, heartbeat and Fe start BDB nodes. - LocalMetastore: It is mainly responsible for managing metadata related to internal catalog. It includes Cluster/Database/Table/Partition/Tablet/ Replica, and implements the API of `ConnectorMetadata` - XXXMgr in GlobalStateMgr Some methods, such as loadxxx and savexxx, transfer them to the corresponding manager instance. For example, transfer `loadExportJob()` and `saveExportJob()` in `GlobalStateMgr` to `ExportMgr`
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
…tarRocks#6315) * Add doc for covar/corr etc funtion Signed-off-by: before-Sunrise <unclejyj@gmail.com> --------- Signed-off-by: before-Sunrise <unclejyj@gmail.com> Co-authored-by: evelyn.zhaojie <everlyn.zhaojie@gmail.com> (cherry picked from commit c3f1994) Co-authored-by: before-Sunrise <71162020+before-Sunrise@users.noreply.github.com> (cherry picked from commit e0d425c) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
…s#6268) (StarRocks#6315)" (StarRocks#6316) This reverts commit 2d87a5e.
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
* Add doc for covar/corr etc funtion Signed-off-by: before-Sunrise <unclejyj@gmail.com> --------- Signed-off-by: before-Sunrise <unclejyj@gmail.com> Co-authored-by: evelyn.zhaojie <everlyn.zhaojie@gmail.com> (cherry picked from commit c3f1994) Co-authored-by: before-Sunrise <71162020+before-Sunrise@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: stephen-shelby stephen5217@163.com
What type of PR is this：
Which issues of this PR fixes ：
related with: #6272
related with #5062
Problem Summary(Required) ：
Goals:
Most of the code in globalstatemgr is transferred to three parts:
It is mainly used to manage Fe/Be/Broker, heartbeat and Fe start BDB nodes.
It is mainly responsible for managing metadata related to internal catalog. It includes Cluster/Database/Table/Partition/Tablet/ Replica, and implements the API of
ConnectorMetadataSome methods, such as loadxxx and savexxx, transfer them to the corresponding manager instance. For example, transfer
loadExportJob()andsaveExportJob()inGlobalStateMgrtoExportMgr