Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix]disable dict optimization when having predicate has dictionary column #5914

Merged
merged 1 commit into from
May 10, 2022
Merged

[BugFix]disable dict optimization when having predicate has dictionary column #5914

merged 1 commit into from
May 10, 2022

Conversation

mchades
Copy link
Contributor

@mchades mchades commented May 10, 2022

What type of PR is this：

  • bug

Which issues of this PR fixes ：

Fixes #5912

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage check]

😍 pass : 5 / 5 (100.00%)

file detail

path covered line new line coverage
🔵 com/starrocks/sql/optimizer/operator/physical/PhysicalHashAggregateOperator.java 5 5 100.00%

@kangkaisen kangkaisen merged commit 0c92d3a into StarRocks:main May 10, 2022
@stdpain
Copy link
Contributor

stdpain commented May 10, 2022

@Mergifyio backport branch-2.2

@stdpain
Copy link
Contributor

stdpain commented May 10, 2022

@Mergifyio backport branch-2.1

mergify bot pushed a commit that referenced this pull request May 10, 2022
@mchades @mergify
disable dict optimization when having predicate has dictionary column (…
3917ec3 
…#5914)

(cherry picked from commit 0c92d3a)
@mergify mergify bot mentioned this pull request May 10, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented May 10, 2022

backport branch-2.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 10, 2022
@mchades @mergify
disable dict optimization when having predicate has dictionary column (…
81d7b78 
…#5914)

(cherry picked from commit 0c92d3a)
@mergify mergify bot mentioned this pull request May 10, 2022
Closed
@mergify
Copy link
Contributor

mergify bot commented May 10, 2022

backport branch-2.1

✅ Backports have been created

stdpain pushed a commit that referenced this pull request May 11, 2022
@mchades @stdpain
disable dict optimization when having predicate has dictionary column (…
3d962e9 
…#5914)

(cherry picked from commit 0c92d3a)
stdpain pushed a commit to stdpain/starrocks-2 that referenced this pull request Jul 25, 2022
@mchades @stdpain
disable dict optimization when having predicate has dictionary column (…
518bfbc 
…StarRocks#5914)
kangkaisen pushed a commit that referenced this pull request Jul 26, 2022
@stdpain @mchades
disable dict optimization when having predicate has dictionary column (…
52bea8b 
…#5914) (#9134)

Co-authored-by: mchades <793098424@qq.com>
jaogoy pushed a commit to jaogoy/starrocks that referenced this pull request Nov 15, 2023
@miomiocat @amber-create
Add paimon catalog (StarRocks#5914)
951312a 
Signed-off-by: miomiocat <284487410@qq.com>
* Update paimon_catalog.md
Co-authored-by: amber-create <48005258@qq.com>
jaogoy pushed a commit to jaogoy/starrocks that referenced this pull request Nov 15, 2023
@mergify @miomiocat
Add paimon catalog (StarRocks#5914) (StarRocks#5970)
5c67ea8 
Signed-off-by: miomiocat <284487410@qq.com>
* Update paimon_catalog.md
Co-authored-by: amber-create <48005258@qq.com>
(cherry picked from commit 951312a)

Co-authored-by: miomiocat <284487410@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@stdpain stdpain stdpain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unknown error when having predicate includes AggregateFunction
4 participants
@mchades @wanpengfei-git @stdpain @kangkaisen