-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Japanese translation (backport #55725) #56278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Japanese support for docs @EsoragotoSpirit can you please work on the dictionary: docs/translation/en-to-ja-configs/language_dicts/ja.yaml I copied the English to Chinese one. The upstream project has Japanese support, and so they have a dictionary already for their terms. It may not be useful to you as they are in a different product space. There are two translated files in this PR, I believe that they have a mix of Japanese and Chinese in them because I used the Chinese dictionary file. The README is updated with instructions to translate to Japanese. Also note the known issues in the README, I will work on those. Signed-off-by: DanRoscigno <dan@roscigno.com> Co-authored-by: EsoragotoSpirit <wanglichen@starrocks.com> (cherry picked from commit 776379e) # Conflicts: # docs/translation/README.md
Cherry-pick of 776379e has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
24 tasks
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
DanRoscigno
previously approved these changes
Feb 26, 2025
Signed-off-by: DanRoscigno <dan@roscigno.com>
DanRoscigno
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Japanese support for docs
@EsoragotoSpirit can you please work on the dictionary:
docs/translation/en-to-ja-configs/language_dicts/ja.yaml
I copied the English to Chinese one. The upstream project has Japanese support, and so they have a dictionary already for their terms. It may not be useful to you as they are in a different product space.
There are two translated files in this PR, I believe that they have a mix of Japanese and Chinese in them because I used the Chinese dictionary file. The README is updated with instructions to translate to Japanese. Also note the known issues in the README, I will work on those.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: