Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] limit max predicate columns when using full analyze predicate column instead of sample all columns on auto collect statistics #56162

Merged

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Feb 21, 2025

Why I'm doing:

Currently, we use full analyze predicate column instead of sample all column in the background auto statistics collection.
If there are too many predicate column in a table, full analyze will also affect the collection performance. So we need to limit the predicate column size.

mysql> select table_id, count(1) from predicate_columns where db_id=90081 and usage != 'normal' group by table_id order by table_id;
+----------+----------+
| table_id | count(1) |
+----------+----------+
|    91092 |        5 |
|    91097 |        2 |
|    91102 |        9 |
|    91137 |       20 |
|    91524 |       14 |
|    91547 |        9 |
|    91570 |        9 |
|    91593 |       10 |
|    91606 |        5 |
|    91611 |        3 |
|    91616 |        4 |
|    91683 |       17 |
|    91706 |        5 |
|    91711 |        2 |
|    91716 |        3 |
|    91721 |       16 |
|    91726 |        9 |
|    91749 |       18 |
|    92136 |        5 |
|    92149 |        7 |
|    92154 |        2 |
|    92159 |       12 |
|    92182 |       20 |
|    92569 |        4 |
+----------+----------+
24 rows in set (0.04 sec)

This is predicate column size in tpcds sql. we use 16 as default value.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stephen-shelby stephen-shelby requested a review from a team as a code owner February 21, 2025 09:05
@stephen-shelby stephen-shelby changed the title [Enhancement] limit max predicate columns when using full analyze predicate column instead of sample all columns on auto collect statistics [UT] limit max predicate columns when using full analyze predicate column instead of sample all columns on auto collect statistics Feb 21, 2025
…dicate column instead of sample all columns on auto collect statistics

Signed-off-by: stephen <stephen5217@163.com>
@stephen-shelby stephen-shelby force-pushed the add_auto_predicate_column_limit branch from 28e5d8e to 4b5a5ec Compare February 21, 2025 09:30
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/statistic/StatisticsCollectJobFactory.java 6 6 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby changed the title [UT] limit max predicate columns when using full analyze predicate column instead of sample all columns on auto collect statistics [Enhancement] limit max predicate columns when using full analyze predicate column instead of sample all columns on auto collect statistics Feb 21, 2025
@stephen-shelby stephen-shelby merged commit a19f5c1 into StarRocks:main Feb 24, 2025
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants