[BugFix] fix inconsistent transaction process if exception thrown

[starrocks-xupeng]

Why I'm doing:

What I'm doing:

1. modify transaction state in memory
2. call afterStateTransform
3. persist transaction log

if step 1 succeeds, step 2 must not throw exception, avoid causing inconsistency between memory info(step 1) and disk info(step 3)

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.4
  • 3.3
  • 3.2
  • 3.1
  • 3.0

[starrocks-cr]

The most risky bug in this code is:
Returning null when txnOperated is false may not be handled properly by the caller, leading to potential null pointer exceptions or logical errors downstream.

You can modify the code like this:

// Check for txnOperated before returning null
if (!txnOperated) {
    LOG.error("Transaction operation failed. Returning default value or taking corrective action.");
    // Handle the null return case more robustly here, e.g., return an empty VisibleStateWaiter.
    return new VisibleStateWaiter(); // Example, adjust to actual required behavior
}

[sonarqubecloud]

Quality Gate failed

Failed conditions
19.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[github-actions]

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

❌ fail : 16 / 38 (42.11%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/lake/compaction/CompactionScheduler.java	0	8	00.00%	[136, 137, 138, 141, 142, 414, 415, 416]
🔵	com/starrocks/transaction/GlobalTransactionMgr.java	1	3	33.33%	[345, 346]
🔵	com/starrocks/transaction/DatabaseTransactionMgr.java	15	27	55.56%	[429, 430, 526, 527, 531, 617, 618, 1289, 1290, 1324, 1994, 1995]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

@Mergifyio backport branch-3.4

[github-actions]

@Mergifyio backport branch-3.3

[mergify]

backport branch-3.4

✅ Backports have been created

• #56240 [BugFix] fix inconsistent transaction process if exception thrown (backport #56153) has been created for branch branch-3.4 but encountered conflicts

[mergify]

backport branch-3.3

✅ Backports have been created

• #56241 [BugFix] fix inconsistent transaction process if exception thrown (backport #56153) has been created for branch branch-3.3 but encountered conflicts

[starrocks-xupeng]

#56242
3.3

[starrocks-xupeng]

#56243
3.4