Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Rename JoinRuntimeFilter to RuntimeFilter #55587

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Feb 6, 2025

Why I'm doing:

The RuntimeFilter is not only used for join operations but is also currently used in TopN operators. In the future, it will be applied to aggr operator as well. To facilitate future extensions, we renamed JoinRuntimeFilter to RuntimeFilter. Subsequently, we will implement different subclasses, such as MinMaxRuntimeFilter, InRuntimeFilter, NotInRuntimeFilter, TopNRuntimeFilter, and so on.

What I'm doing:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: trueeyu <lxhhust350@qq.com>
@mergify mergify bot assigned trueeyu Feb 6, 2025
@trueeyu trueeyu marked this pull request as ready for review February 6, 2025 03:20
@trueeyu trueeyu requested review from a team as code owners February 6, 2025 03:20
Signed-off-by: trueeyu <lxhhust350@qq.com>
Signed-off-by: trueeyu <lxhhust350@qq.com>
@dirtysalt dirtysalt enabled auto-merge (squash) February 6, 2025 03:53
Copy link

github-actions bot commented Feb 6, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Feb 6, 2025

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Feb 6, 2025

[BE Incremental Coverage Report]

pass : 68 / 82 (82.93%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/hash_join_node.cpp 0 1 00.00% [961]
🔵 be/src/formats/orc/orc_chunk_reader.cpp 1 2 50.00% [1128]
🔵 be/src/exec/chunks_sorter_topn.cpp 1 2 50.00% [130]
🔵 be/src/exec/chunks_sorter.h 2 3 66.67% [131]
🔵 be/src/exprs/runtime_filter.h 11 16 68.75% [262, 558, 559, 693, 694]
🔵 be/src/exprs/runtime_filter_bank.cpp 20 25 80.00% [201, 210, 341, 725, 726]
🔵 be/src/storage/runtime_range_pruner.hpp 2 2 100.00% []
🔵 be/src/exec/pipeline/runtime_filter_types.h 2 2 100.00% []
🔵 be/src/runtime/runtime_filter_cache.cpp 4 4 100.00% []
🔵 be/src/connector/connector.cpp 1 1 100.00% []
🔵 be/src/runtime/runtime_filter_worker.cpp 6 6 100.00% []
🔵 be/src/exec/hash_joiner.cpp 2 2 100.00% []
🔵 be/src/exprs/runtime_filter.cpp 5 5 100.00% []
🔵 be/src/exec/chunks_sorter_heap_sort.cpp 3 3 100.00% []
🔵 be/src/exprs/runtime_filter_bank.h 5 5 100.00% []
🔵 be/src/exec/olap_scan_prepare.cpp 2 2 100.00% []
🔵 be/src/exprs/min_max_predicate.h 1 1 100.00% []

@dirtysalt dirtysalt merged commit df1cb6a into StarRocks:main Feb 6, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants