Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Convert Trino function from_iso8601_timestamp -> timestamp #55573

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

click9000
Copy link

Why I'm doing:

When sql_dialect=trino, it doesn't convert Trino function from_iso8601_timestamp -> timestamp

What I'm doing:

Convert Trino function from_iso8601_timestamp -> timestamp
image

Trino doc for from_iso8601_timestamp function - https://trino.io/docs/current/functions/datetime.html

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

for function from_iso8601_timestamp -> timestamp

Signed-off-by: Craig <117254390+click9000@users.noreply.github.com>
unit test for transforming Trino function: from_iso8601_timestamp -> timestamp

Signed-off-by: Craig <117254390+click9000@users.noreply.github.com>
@click9000 click9000 requested a review from a team as a code owner February 5, 2025 19:46
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants