[BugFix] Fix window cumulative algorithm for max/min with string type #55537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| update(ctx, columns, state, current_frame_last_position); | ||
| } | ||
| } | ||
|
|
||
| void merge(FunctionContext* ctx, const Column* column, AggDataPtr __restrict state, size_t row_num) const override { | ||
| DCHECK(column->is_binary()); | ||
| Slice value = column->get(row_num).get_slice(); |
There was a problem hiding this comment.
The most risky bug in this code is:
Potential out-of-bounds access when accessing null_column->raw_data() if the null column isn't actually available or properly casted.
You can modify the code like this:
if (has_null && columns[1]->is_nullable()) {
const auto null_column = down_cast<const NullColumn*>(columns[1]);
const uint8_t* f_data = null_column->raw_data();
for (size_t i = frame_start; i < frame_end; ++i) {
if (f_data[i] == 0) {
update(ctx, columns, state, i);
}
}
} else if (!has_null) {
update_batch_single_state_with_frame(ctx, state, columns, partition_start, partition_end,
frame_start, frame_end);
}Signed-off-by: before-Sunrise <unclejyj@gmail.com>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 20 / 22 (90.91%) file detail
|
kangkaisen
approved these changes
Feb 5, 2025
silverbullet233
approved these changes
Feb 5, 2025
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
This was referenced Feb 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:'
Fixes #55532
#54849 support cumulative algorithm for max/min, but forgot to support string type, which is a Specialized template class
we can change be config: pipeline_analytic_enable_removable_cumulative_process to false to bypass this issue temporarily
What I'm doing:
support string type
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: