Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix string format in HyperLogLog::to_string #55409

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

decster
Copy link
Contributor

@decster decster commented Jan 24, 2025

Why I'm doing:

E20250124 15:06:48.361545 138417362238144 substitute.cc:39] strings::Substitute format string invalid: asked for "$2", but only 2 args were given.  Full format string was: "cardinality:$1\ntype:$2".

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: Binglin Chang <decstery@gmail.com>
@decster decster requested a review from a team as a code owner January 24, 2025 07:25
@github-actions github-actions bot added the 3.4 label Jan 24, 2025
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/types/hll.cpp 0 1 00.00% [593]

@alvin-celerdata alvin-celerdata merged commit e9229b0 into StarRocks:main Feb 7, 2025
47 of 48 checks passed
Copy link

github-actions bot commented Feb 7, 2025

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Feb 7, 2025
Copy link
Contributor

mergify bot commented Feb 7, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 7, 2025
wanpengfei-git pushed a commit that referenced this pull request Feb 7, 2025
#55683)

Co-authored-by: Binglin Chang <decstery@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants