-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix array_map crash #55383
Merged
Merged
[BugFix] fix array_map crash #55383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueeyu
reviewed
Jan 24, 2025
trueeyu
approved these changes
Jan 24, 2025
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
silverbullet233
approved these changes
Jan 24, 2025
[BE Incremental Coverage Report]✅ pass : 20 / 23 (86.96%) file detail
|
@Mergifyio backport branch-3.4 |
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Signed-off-by: before-Sunrise <unclejyj@gmail.com> (cherry picked from commit d3f5052)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Signed-off-by: before-Sunrise <unclejyj@gmail.com> (cherry picked from commit d3f5052) # Conflicts: # be/src/column/adaptive_nullable_column.h # be/src/column/binary_column.cpp # be/src/column/binary_column.h # be/src/column/column.h # be/src/column/const_column.cpp # be/src/column/const_column.h # be/src/column/fixed_length_column_base.cpp # be/src/column/fixed_length_column_base.h # be/src/column/nullable_column.cpp # be/src/column/nullable_column.h
18 tasks
before-Sunrise
added a commit
to before-Sunrise/starrocks
that referenced
this pull request
Feb 6, 2025
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
24 tasks
silverbullet233
pushed a commit
that referenced
this pull request
Feb 6, 2025
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
for BinaryColumnBase::replicate, it can allocate a huge vector, which size exceed uint32 max, so need to call upgrade_if_overflow to avoid check faild:
F20250123 12:27:53.005990 140324118660672 binary_column.cpp:36] Check failed: _bytes.size() == _offsets.back() (20624569792 vs. 3444700608)
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: