Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Write combined txn log parallel #55143

Merged
merged 8 commits into from
Jan 26, 2025
Merged

[Enhancement] Write combined txn log parallel #55143

merged 8 commits into from
Jan 26, 2025

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Jan 16, 2025 •
edited
Loading

Why I'm doing:

If the import task involves multiple partitions, the combined transaction log will be written one by one, which may slowdown the import speed.

What I'm doing:

Write combined txn log parallel

write combined txn log for 100 partitions.
before this pr

I20250110 15:44:43.331159 139757477246720 tablet_sink_sender.cpp:384] write_combined_txn_log non-parallel cost time: 1545

after this pr

I20250110 15:46:47.941779 139757477246720 tablet_sink_sender.cpp:376] write_combined_txn_log parallel cost time: 140

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@sevev sevev requested review from a team as code owners January 16, 2025 07:47
@mergify mergify bot assigned sevev Jan 16, 2025
@sevev sevev force-pushed the put_combined_txn_log_parallel branch from 4e26288 to 6e05e08 Compare January 16, 2025 11:46
@sevev sevev requested a review from a team as a code owner January 17, 2025 09:55
kevincai
kevincai reviewed Jan 23, 2025
View reviewed changes
be/src/common/config.h Show resolved Hide resolved
be/src/common/config.h Show resolved Hide resolved
be/src/exec/write_combined_txn_log.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/tablet_manager.cpp Show resolved Hide resolved
be/test/storage/lake/write_combined_txn_log_test.cpp Outdated Show resolved Hide resolved
@sevev sevev requested a review from kevincai January 23, 2025 07:52
kevincai
kevincai reviewed Jan 23, 2025
View reviewed changes
be/src/exec/tablet_sink_sender.cpp Outdated Show resolved Hide resolved
be/src/exec/write_combined_txn_log.cpp Outdated Show resolved Hide resolved
sevev added 5 commits January 23, 2025 18:00
@sevev
write combined txn log parallel
9514e83 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
update
050a4ed 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
update
da40588 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
add ut
733b4f0 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
update
6ec701a 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev sevev force-pushed the put_combined_txn_log_parallel branch from f7605e6 to 6ec701a Compare January 23, 2025 11:11
@sevev sevev requested a review from kevincai January 24, 2025 02:19
@sevev
update
9b5a2af 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
update
d8d1449 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
update
2a76320 
Signed-off-by: sevev <qiangzh95@gmail.com>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 43 / 49 (87.76%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/tablet_sink_sender.cpp 0 2 00.00% [373, 374]
🔵 be/src/exec/write_combined_txn_log.cpp 36 40 90.00% [51, 52, 71, 72]
🔵 be/src/runtime/exec_env.h 1 1 100.00% []
🔵 be/src/runtime/exec_env.cpp 4 4 100.00% []
🔵 be/src/storage/lake/tablet_manager.cpp 2 2 100.00% []

@sevev sevev requested a review from wyb January 26, 2025 01:45
@wyb wyb enabled auto-merge (squash) January 26, 2025 02:46
@wyb wyb merged commit af3d78f into StarRocks:main Jan 26, 2025
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 26, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 26, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 26, 2025
@sevev @mergify
[Enhancement] Write combined txn log parallel (#55143)
6ab51ce 
Signed-off-by: sevev <qiangzh95@gmail.com>
(cherry picked from commit af3d78f)
mergify bot pushed a commit that referenced this pull request Jan 26, 2025
@sevev @mergify
[Enhancement] Write combined txn log parallel (#55143)
880c43a 
Signed-off-by: sevev <qiangzh95@gmail.com>
(cherry picked from commit af3d78f)

# Conflicts:
#	be/src/storage/lake/tablet_manager.cpp
This was referenced Jan 26, 2025
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Jan 26, 2025
@mergify @sevev
[Enhancement] Write combined txn log parallel (backport #55143) (#55445)
b411fa4 
Signed-off-by: sevev <qiangzh95@gmail.com>
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 26, 2025
@mergify @sevev
[Enhancement] Write combined txn log parallel (backport #55143) (#55444)
5e19346 
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@kevincai kevincai kevincai approved these changes

@wyb wyb wyb approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@sevev sevev

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevev @kevincai @wyb @stdpain