Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize code in arm #55072

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

before-Sunrise
Copy link
Contributor

@before-Sunrise before-Sunrise commented Jan 14, 2025

Why I'm doing:

arm is slower than x86 in some cases

What I'm doing:

  1. vectorize rf's insert_hash using Neon intrinsics
  2. streamvbyte's cmakelist is wrong, which cause performance downgrade in arm because vectorization cannot work properly
  3. arm's int128_mul_overflow is super slow becase of divide operation, __builtin_mul_overflow(int128_t a, int128_t b, int128_t* c) is fast enough when compile with clang17, I wii change arm's default compiler into clang17 in another pr. we can gain significant performance improvement with clang 17 and --rtlib=compiler-rt when data type is int128, many compiler system function is super fast if using clang17 and --rtlib=compiler-rt like "__floattidf"

before this pr, rf insert_hash/ streamvbyte's decode/int128_mul_overflow is at least 3 times slower than x86, after this pr and clang17, arm is faster or equal to x86 in these cases

for example:
select count(t.a) from (select cast(id_decimal as float) as a from test_all_type_select) as t
x86: 0.11s
arm:0.36s
arm-opt(with this pr): 0.11s

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: before-Sunrise <unclejyj@gmail.com>
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants