Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] enable event scheduler by default #54827

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Jan 8, 2025

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stdpain stdpain requested a review from a team as a code owner January 8, 2025 02:41
@mergify mergify bot assigned stdpain Jan 8, 2025
@stdpain stdpain force-pushed the enable_event_scheduler_by_default branch from 4b8bf68 to 373e2e3 Compare January 14, 2025 03:21
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
@stdpain stdpain force-pushed the enable_event_scheduler_by_default branch from 373e2e3 to 48e949b Compare January 14, 2025 05:58
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 46 / 69 (66.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/fragment_context.h 0 5 00.00% [279, 280, 281, 282, 284]
🔵 be/src/exec/pipeline/query_context.cpp 0 10 00.00% [690, 691, 692, 693, 694, 695, 696, 697, 699, 700]
🔵 be/src/exec/pipeline/pipeline_driver_poller.cpp 0 8 00.00% [267, 268, 269, 270, 271, 272, 274, 276]
🔵 be/src/exec/pipeline/exchange/exchange_sink_operator.cpp 5 5 100.00% []
🔵 be/src/exec/pipeline/fragment_executor.cpp 1 1 100.00% []
🔵 be/src/exec/query_cache/multilane_operator.cpp 1 1 100.00% []
🔵 be/src/exec/query_cache/conjugate_operator.cpp 2 2 100.00% []
🔵 be/src/exec/pipeline/pipeline_driver.h 3 3 100.00% []
🔵 be/src/exec/pipeline/fragment_context.cpp 2 2 100.00% []
🔵 be/src/exec/pipeline/pipeline_driver.cpp 7 7 100.00% []
🔵 be/src/exec/pipeline/nljoin/nljoin_probe_operator.cpp 1 1 100.00% []
🔵 be/src/exec/pipeline/schedule/event_scheduler.cpp 1 1 100.00% []
🔵 be/src/exec/pipeline/schedule/timeout_tasks.h 2 2 100.00% []
🔵 be/src/exec/pipeline/scan/chunk_buffer_limiter.cpp 2 2 100.00% []
🔵 be/src/exec/exchange_node.cpp 2 2 100.00% []
🔵 be/src/exec/pipeline/scan/chunk_buffer_limiter.h 4 4 100.00% []
🔵 be/src/exec/pipeline/wait_operator.cpp 1 1 100.00% []
🔵 be/src/exec/pipeline/schedule/observer.cpp 7 7 100.00% []
🔵 be/src/exec/pipeline/schedule/timeout_tasks.cpp 3 3 100.00% []
🔵 be/src/exec/pipeline/scan/connector_scan_operator.h 1 1 100.00% []
🔵 be/src/exec/pipeline/schedule/observer.h 1 1 100.00% []

@kangkaisen kangkaisen merged commit e5375da into StarRocks:main Jan 23, 2025
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants