Refine StreamLoadPipe::append_and_flush() #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickif
reviewed
Apr 24, 2022
| @@ -200,41 +204,8 @@ class StreamLoadPipe : public MessageBodySink, public FileReader { | |||
| } | |||
|
|
|||
| private: | |||
| // read the next buffer from _buf_queue | |||
| Status _read_next_buffer(std::unique_ptr<uint8_t[]>* out, size_t* out_cap, size_t* out_sz, size_t padding) { | |||
There was a problem hiding this comment.
Nice catch. I'm about to delete this.
|
Could |
The unit test still relies on this method now. |
Removed, PTAL |
rickif
approved these changes
Apr 24, 2022
imay
approved these changes
Apr 24, 2022
wyb
approved these changes
Apr 25, 2022
blackstar-baba
pushed a commit
to blackstar-baba/starrocks
that referenced
this pull request
Apr 28, 2022
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
…tarRocks#5452) This reverts commit 32b9ce6.
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
…tarRocks#5452) (StarRocks#5454) This reverts commit 32b9ce6. (cherry picked from commit 059dcee) Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
…tarRocks#5452) (StarRocks#5453) This reverts commit 32b9ce6. (cherry picked from commit 059dcee) Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Summary
Should flush the data in
_write_bufbefore writing the data passed byappend_and_flush