-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix query cache crash when enable group execution #54363
Merged
stdpain
merged 1 commit into
StarRocks:main
from
stdpain:fix_group_execution_crash_with_query_cache
Dec 26, 2024
Merged
[BugFix] Fix query cache crash when enable group execution #54363
stdpain
merged 1 commit into
StarRocks:main
from
stdpain:fix_group_execution_crash_with_query_cache
Dec 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When group execution and query cache are turned on, if a runtime filter is pushed down to AGG instead of SCAN, it will cause the colocate runtime filter to use the wrong runtime filter, resulting in a crash. Signed-off-by: stdpain <drfeng08@gmail.com>
LiShuMing
approved these changes
Dec 26, 2024
Seaven
approved these changes
Dec 26, 2024
satanson
approved these changes
Dec 26, 2024
stdpain
changed the title
[BugFix] Fix query cache crashh when enable group execution
[BugFix] Fix query cache crash when enable group execution
Dec 26, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 13 / 13 (100.00%) file detail
|
@Mergifyio backport branch-3.4 |
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 26, 2024
Signed-off-by: stdpain <drfeng08@gmail.com> (cherry picked from commit 8fad835)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 26, 2024
Signed-off-by: stdpain <drfeng08@gmail.com> (cherry picked from commit 8fad835)
18 tasks
maggie-zhu
pushed a commit
to maggie-zhu/starrocks
that referenced
this pull request
Jan 6, 2025
…#54363) Signed-off-by: stdpain <drfeng08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When group execution and query cache are turned on, if a runtime filter is pushed down to AGG instead of SCAN, it will cause the colocate runtime filter to use the wrong runtime filter, resulting in a crash.
I apply this patch to make runtime filter evaluate on aggregate node:
then execution the test case:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: