Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] support config s3client request timeout for shared-data fslib #54211

Merged
merged 1 commit into from
Dec 25, 2024
Merged

[Enhancement] support config s3client request timeout for shared-data fslib #54211

merged 1 commit into from
Dec 25, 2024

Conversation

kevincai
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@kevincai
[Enhancement] support config s3client request timeout for shared-data…
ef32b06 
… fslib

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai requested review from a team as code owners December 23, 2024 02:54
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 2 / 4 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/service/staros_worker.cpp 1 2 50.00% [400]
🔵 be/src/http/action/update_config_action.cpp 1 2 50.00% [345]

@wyb wyb enabled auto-merge (squash) December 24, 2024 15:39
@alvin-celerdata alvin-celerdata merged commit ac91dbe into StarRocks:main Dec 25, 2024
53 of 54 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 25, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 25, 2024
@kevincai @mergify
[Enhancement] support config s3client request timeout for shared-data…
db726f8 
… fslib (#54211)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ac91dbe)
@mergify mergify bot mentioned this pull request Dec 25, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 25, 2024
@kevincai @mergify
[Enhancement] support config s3client request timeout for shared-data…
24760b4 
… fslib (#54211)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ac91dbe)
mergify bot pushed a commit that referenced this pull request Dec 25, 2024
@kevincai @mergify
[Enhancement] support config s3client request timeout for shared-data…
15a155f 
… fslib (#54211)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ac91dbe)

# Conflicts:
#	be/src/common/config.h
#	be/src/service/staros_worker.cpp
This was referenced Dec 25, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2024
@mergify @kevincai
[Enhancement] support config s3client request timeout for shared-data…
e0cb762 
… fslib (backport #54211) (#54287)

Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2024
@mergify @kevincai
[Enhancement] support config s3client request timeout for shared-data…
6fb4d89 
… fslib (backport #54211) (#54289)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2024
@mergify @kevincai
[Enhancement] support config s3client request timeout for shared-data…
518707a 
… fslib (backport #54211) (#54288)

Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
kevincai added a commit to kevincai/starrocks that referenced this pull request Dec 30, 2024
@kevincai
[Doc] add doc for starlet_fslib_s3client_request_timeout_ms
46646f9 
* Refs StarRocks#54211

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai mentioned this pull request Dec 30, 2024
Merged
24 tasks
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
@kevincai
[Enhancement] support config s3client request timeout for shared-data…
f6ae211 
… fslib (StarRocks#54211)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
This was referenced Jan 7, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

@xiangguangyxg xiangguangyxg xiangguangyxg approved these changes

@tracymacding tracymacding tracymacding approved these changes

@wyb wyb wyb approved these changes

Assignees

@kevincai kevincai

Labels
3.2-merged 3.3-merged 3.4-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevincai @wyb @tracymacding @xiangguangyxg @alvin-celerdata