[BugFix] Fix Left Anti join null_array UAF #53634

stdpain · 2024-12-06T02:43:37Z

Why I'm doing:

null_array should be reset when input has not null.

What I'm doing:

Fixes

<pre style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(26, 26, 26, 0.3); -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; overflow-wrap: break-word; white-space: pre-wrap;">3.2.12-ee RELEASE (build f1496f5)
query_id:c0a108e5-b23e-11ef-b7ce-58a2e1bc0436, fragment_instance:c0a108e5-b23e-11ef-b7ce-58a2e1bc0438
tracker:process consumption: 549134011440
tracker:jemalloc_metadata consumption: 17448843280
tracker:jemalloc_fragmentation consumption: 10592096488
tracker:query_pool consumption: 3081171264
tracker:query_pool/connector_scan consumption: 0
tracker:load consumption: 1528657726
tracker:metadata consumption: 93686169928
tracker:tablet_metadata consumption: 166203468
tracker:rowset_metadata consumption: 538173983
tracker:segment_metadata consumption: 6659708510
tracker:column_metadata consumption: 86322083967
tracker:tablet_schema consumption: 5117364
tracker:segment_zonemap consumption: 1124249792
tracker:short_key_index consumption: 5461168904
tracker:column_zonemap_index consumption: 28078810943
tracker:ordinal_index consumption: 51134061536
tracker:bitmap_index consumption: 0
tracker:bloom_filter_index consumption: 7025888
tracker:compaction consumption: 2457592920
tracker:schema_change consumption: 0
tracker:column_pool consumption: 0
tracker:page_cache consumption: 263771320960
tracker:update consumption: 110879673908
tracker:chunk_allocator consumption: 2137550840
tracker:clone consumption: 0
tracker:consistency consumption: 24890424
tracker:datacache consumption: 0
tracker:replication consumption: 0
*** Aborted at 1733316816 (unix time) try "date -d @1733316816" if you are using GNU date ***
PC: @          0x37bacdb starrocks::JoinHashMap&lt;&gt;::_ZN9starrocks11JoinHashMapILNS_11LogicalTypeE17ENS_23SerializedJoinBuildFuncENS_23SerializedJoinProbeFuncEE33_probe_from_ht_for_left_anti_joinEPNS_12RuntimeStateERKSt6vectorINS_5SliceESaIS8_EESC_.actor()
*** SIGSEGV (@0x0) received by PID 44699 (TID 0x1465a04da640) from PID 0; stack trace: ***
    @          0x6cb5a62 google::(anonymous namespace)::FailureSignalHandler()
    @     0x14691162b9b9 os::Linux::chained_handler()
    @     0x146911631c7a JVM_handle_linux_signal
    @     0x146911623a4c signalHandler()
    @     0x14691063e6f0 (unknown)
    @          0x37bacdb starrocks::JoinHashMap&lt;&gt;::_ZN9starrocks11JoinHashMapILNS_11LogicalTypeE17ENS_23SerializedJoinBuildFuncENS_23SerializedJoinProbeFuncEE33_probe_from_ht_for_left_anti_joinEPNS_12RuntimeStateERKSt6vectorINS_5SliceESaIS8_EESC_.actor()
    @          0x37a9e5c starrocks::JoinHashMap&lt;&gt;::_probe_coroutine&lt;&gt;()
    @          0x3860e84 starrocks::JoinHashMap&lt;&gt;::probe()
    @          0x37a3d46 starrocks::JoinHashTable::probe()
    @          0x3ce25ca starrocks::HashJoinProber::probe_chunk()
    @          0x3cddad4 starrocks::HashJoiner::_pull_probe_output_chunk()
    @          0x3cddd32 starrocks::HashJoiner::pull_chunk()
    @          0x3b16aa9 starrocks::pipeline::HashJoinProbeOperator::pull_chunk()
    @          0x3ac36e6 starrocks::pipeline::PipelineDriver::process()
    @          0x3ab55bf starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
    @          0x302f5ec starrocks::ThreadPool::dispatch_thread()
    @          0x3028b6a starrocks::Thread::supervise_thread()</pre>

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: stdpain <drfeng08@gmail.com>

github-actions · 2024-12-06T04:30:56Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-06T04:30:57Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-06T04:41:09Z

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/exec/join_hash_map.tpp	1	1	100.00%	[]
🔵	be/src/exec/join_hash_map.cpp	1	1	100.00%	[]

github-actions · 2024-12-06T05:49:19Z

@Mergifyio backport branch-3.4

github-actions · 2024-12-06T05:49:20Z

@Mergifyio backport branch-3.3

github-actions · 2024-12-06T05:49:22Z

@Mergifyio backport branch-3.2

github-actions · 2024-12-06T05:49:23Z

@Mergifyio backport branch-3.1

github-actions · 2024-12-06T05:49:24Z

@Mergifyio backport branch-3.0

mergify · 2024-12-06T05:49:44Z

backport branch-3.4

✅ Backports have been created

#53643 [BugFix] Fix Left Anti join null_array UAF (backport #53634) has been created for branch branch-3.4

mergify · 2024-12-06T05:49:45Z

backport branch-3.3

✅ Backports have been created

#53644 [BugFix] Fix Left Anti join null_array UAF (backport #53634) has been created for branch branch-3.3

mergify · 2024-12-06T05:49:46Z

backport branch-3.2

✅ Backports have been created

#53645 [BugFix] Fix Left Anti join null_array UAF (backport #53634) has been created for branch branch-3.2

mergify · 2024-12-06T05:49:48Z

backport branch-3.1

✅ Backports have been created

#53646 [BugFix] Fix Left Anti join null_array UAF (backport #53634) has been created for branch branch-3.1 but encountered conflicts

mergify · 2024-12-06T05:49:49Z

backport branch-3.0

✅ Backports have been created

#53647 [BugFix] Fix Left Anti join null_array UAF (backport #53634) has been created for branch branch-3.0 but encountered conflicts

Signed-off-by: stdpain <drfeng08@gmail.com> (cherry picked from commit e0a00b3)

Signed-off-by: stdpain <drfeng08@gmail.com> (cherry picked from commit e0a00b3) # Conflicts: # test/sql/test_join/R/test_null_aware_anti_join # test/sql/test_join/T/test_null_aware_anti_join

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com> (cherry picked from commit af7e8b0)

…#53645) (#53823) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com> Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>

[BugFix] Fix Left Anti join null_array UAF

408f054

Signed-off-by: stdpain <drfeng08@gmail.com>

stdpain requested a review from a team as a code owner December 6, 2024 02:43

github-actions bot added 3.4 3.3 3.2 3.1 3.0 labels Dec 6, 2024

mergify bot assigned stdpain Dec 6, 2024

Seaven approved these changes Dec 6, 2024

View reviewed changes

trueeyu approved these changes Dec 6, 2024

View reviewed changes

stdpain merged commit e0a00b3 into StarRocks:main Dec 6, 2024
55 checks passed

github-actions bot removed 3.4 3.3 labels Dec 6, 2024

github-actions bot removed the 3.2 label Dec 6, 2024

github-actions bot removed the 3.1 label Dec 6, 2024

github-actions bot removed the 3.0 label Dec 6, 2024

mergify bot pushed a commit that referenced this pull request Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (#53634)

20b49a2

Signed-off-by: stdpain <drfeng08@gmail.com> (cherry picked from commit e0a00b3)

mergify bot mentioned this pull request Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) #53643

Merged

42 tasks

mergify bot pushed a commit that referenced this pull request Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (#53634)

b01c4f3

Signed-off-by: stdpain <drfeng08@gmail.com> (cherry picked from commit e0a00b3)

mergify bot pushed a commit that referenced this pull request Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (#53634)

5c7fbb6

Signed-off-by: stdpain <drfeng08@gmail.com> (cherry picked from commit e0a00b3)

This was referenced Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) #53644

Merged

[BugFix] Fix Left Anti join null_array UAF (backport #53634) #53645

Merged

mergify bot mentioned this pull request Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) #53646

Merged

42 tasks

mergify bot mentioned this pull request Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) #53647

Closed

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Dec 6, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) (#53643)

066156d

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>

github-actions bot added the 3.4-merged label Dec 6, 2024

wanpengfei-git pushed a commit that referenced this pull request Dec 9, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) (#53645)

af7e8b0

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>

github-actions bot added the 3.2-merged label Dec 9, 2024

wanpengfei-git pushed a commit that referenced this pull request Dec 9, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) (#53644)

212e84a

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>

github-actions bot added the 3.3-merged label Dec 9, 2024

mergify bot added a commit that referenced this pull request Dec 11, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) (#53645)

0583192

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com> (cherry picked from commit af7e8b0)

mergify bot mentioned this pull request Dec 11, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) (backport #53645) #53823

Merged

42 tasks

andyziye pushed a commit that referenced this pull request Dec 11, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) (backport …

f1ddf4d

…#53645) (#53823) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2024

[BugFix] Fix Left Anti join null_array UAF (backport #53634) (#53646)

0651872

Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com> Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>

github-actions bot added the 3.1-merged label Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix Left Anti join null_array UAF #53634

[BugFix] Fix Left Anti join null_array UAF #53634

stdpain commented Dec 6, 2024 •

edited

Loading

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

[BugFix] Fix Left Anti join null_array UAF #53634

[BugFix] Fix Left Anti join null_array UAF #53634

Conversation

stdpain commented Dec 6, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

github-actions bot commented Dec 6, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Dec 6, 2024

[FE Incremental Coverage Report]

github-actions bot commented Dec 6, 2024

[BE Incremental Coverage Report]

file detail

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

mergify bot commented Dec 6, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 6, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 6, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 6, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 6, 2024 • edited Loading

✅ Backports have been created

stdpain commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading

mergify bot commented Dec 6, 2024 •

edited

Loading