Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix feedback when checking if a tuning guide needs to be generated #53513

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[BugFix] fix feedback when checking if a tuning guide needs to be generated #53513

merged 1 commit into from
Dec 5, 2024

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Dec 4, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@github-actions github-actions bot added the 3.4 label Dec 4, 2024
@stephen-shelby stephen-shelby force-pushed the fix_feedback_agg branch 2 times, most recently from a28f2ec to 765fbfc Compare December 4, 2024 02:21
@stephen-shelby stephen-shelby changed the title [BugFix] fix feedback when checking if a tuning guide needs to be generated [UT] fix feedback when checking if a tuning guide needs to be generated Dec 4, 2024
@stephen-shelby stephen-shelby changed the title [UT] fix feedback when checking if a tuning guide needs to be generated [BugFix] fix feedback when checking if a tuning guide needs to be generated Dec 4, 2024
kangkaisen
kangkaisen previously approved these changes Dec 4, 2024
View reviewed changes
Seaven
Seaven previously approved these changes Dec 4, 2024
View reviewed changes
@stephen-shelby
[BugFix] fix feedback when checking if a tuning guide needs to be gen…
985d28f 
…erated

Signed-off-by: stephen <stephen5217@163.com>
@stephen-shelby stephen-shelby dismissed stale reviews from Seaven and kangkaisen via 985d28f December 4, 2024 11:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/feedback/analyzer/StreamingAggTuningAnalyzer.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@ZiheLiu ZiheLiu merged commit f8a9af9 into StarRocks:main Dec 5, 2024
49 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 5, 2024
@stephen-shelby stephen-shelby deleted the fix_feedback_agg branch December 5, 2024 02:48
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 5, 2024
@stephen-shelby @mergify
[BugFix] fix feedback when checking if a tuning guide needs to be gen…
0b48064 
…erated (#53513)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit f8a9af9)
@mergify mergify bot mentioned this pull request Dec 5, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 5, 2024
@mergify @stephen-shelby
[BugFix] fix feedback when checking if a tuning guide needs to be gen…
265e1bf 
…erated (backport #53513) (#53576)

Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@ZiheLiu ZiheLiu ZiheLiu approved these changes

@kangkaisen kangkaisen kangkaisen left review comments

Assignees

@stephen-shelby stephen-shelby

Labels
3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephen-shelby @Seaven @kangkaisen @ZiheLiu