Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add limit operator before union gather #53102

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Nov 21, 2024

Why I'm doing:

baseline:

mysql>   select  to_bitmap(1) FROM TABLE(generate_series(0, 655350)) union all select bitmap_agg(lo_orderkey) from lineorder group by lo_linenumber limit 1;
+--------------+
| to_bitmap(1) |
+--------------+
| NULL         |
+--------------+
1 row in set (7.42 sec)

patched:

mysql> select  to_bitmap(1) FROM TABLE(generate_series(0, 655350)) union all select bitmap_agg(lo_orderkey) from lineorder group by lo_linenumber limit 1;
+--------------+
| to_bitmap(1) |
+--------------+
| NULL         |
+--------------+
1 row in set (0.04 sec)

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: stdpain <drfeng08@gmail.com>
@stdpain stdpain requested a review from a team as a code owner November 21, 2024 12:22
@stdpain stdpain changed the title [Enhancement] add limit operator in before union gather [Enhancement] add limit operator before union gather Nov 22, 2024
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/union_node.cpp 4 4 100.00% []

@stdpain stdpain merged commit 5411897 into StarRocks:main Nov 22, 2024
65 of 66 checks passed
Copy link

@Mergifyio backport branch-3.4

Copy link

@Mergifyio backport branch-3.3

Copy link
Contributor

mergify bot commented Nov 22, 2024

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 22, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 22, 2024
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 5411897)
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 5411897)
wanpengfei-git pushed a commit that referenced this pull request Nov 22, 2024
#53121)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 22, 2024
#53120)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
@stdpain stdpain deleted the add_limit_before_gather branch December 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants